linux-kernel - Re: [PATCH v1 1/1] thermal: rcar_gen3_thermal: request IRQ after device initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190424084147.7ztvgxd7odaojqg6@verge.net.au>
Date:   Wed, 24 Apr 2019 10:41:47 +0200
From:   Simon Horman <horms@...ge.net.au>
To:     Eugeniu Rosca <erosca@...adit-jv.com>
Cc:     Jiada Wang <jiada_wang@...tor.com>, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org, Zhang Rui <rui.zhang@...el.com>,
        Eduardo Valentin <edubezval@...il.com>,
        Niklas Söderlund 
        <niklas.soderlund+renesas@...natech.se>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
        Marek Vasut <marek.vasut+renesas@...il.com>,
        Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
        Hien Dang <hien.dang.eb@...esas.com>,
        Fabrizio Castro <fabrizio.castro@...renesas.com>,
        Dien Pham <dien.pham.ry@...esas.com>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Biju Das <biju.das@...renesas.com>,
        "George G. Davis" <george_davis@...tor.com>,
        Joshua Frkuska <joshua_frkuska@...tor.com>,
        Eugeniu Rosca <roscaeugeniu@...il.com>
Subject: Re: [PATCH v1 1/1] thermal: rcar_gen3_thermal: request IRQ after
 device initialization

On Tue, Apr 23, 2019 at 01:24:08PM +0200, Eugeniu Rosca wrote:
> Hi Simon,
> 
> On Tue, Apr 23, 2019 at 12:01:07PM +0200, Simon Horman wrote:
> > On Tue, Apr 16, 2019 at 07:48:30PM +0200, Eugeniu Rosca wrote:
> > > Hi Jiada,
> > > 
> > > Adding below people, since they've made recent contributions to the
> > > driver and might be interested in your patch:
> > > 
> > > git log master --since="1 year" -- drivers/thermal/rcar_gen3_thermal.c \
> > >     | grep -o "\-by:.*" | sed 's/\-by: //' | sort | uniq -c | sort -rn
> > >       7 Eduardo Valentin <edubezval@...il.com>
> > >       6 Simon Horman <horms+renesas@...ge.net.au>
> > >       5 Niklas Söderlund <niklas.soderlund+renesas@...natech.se>
> > >       2 Geert Uytterhoeven <geert+renesas@...der.be>
> > >       1 Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
> > >       1 Marek Vasut <marek.vasut+renesas@...il.com>
> > >       1 Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
> > >       1 Hien Dang <hien.dang.eb@...esas.com>
> > >       1 Fabrizio Castro <fabrizio.castro@...renesas.com>
> > >       1 Dien Pham <dien.pham.ry@...esas.com>
> > >       1 Daniel Lezcano <daniel.lezcano@...aro.org>
> > >       1 Biju Das <biju.das@...renesas.com>
> > > 
> > > I confirm that loading and unloading the rcar3 thermal driver in a
> > > loop produces soft lockup using v5.1-rc5-10-g618d919cae2f on
> > > H3-ES2.0-Salvator-X. 
> > > 
> > > Full log and .config can be found here:
> > > https://gist.github.com/erosca/1f76b6dd897cdc39581fca475155e363
> > > 
> > > I post an excerpt from the above [1] (why not including it in the
> > > description?). Also, why not rephrasing the commit summary line in such
> > > a way that everybody understands this patch fixes a severe issue, e.g.
> > > "thermal: rcar_gen3_thermal: Fix soft lockup on probe" ?
> > > 
> > > BTW, with this patch applied I left the thermal driver being
> > > loaded/unloaded on the target for over one hour w/o seeing the issue
> > > reproduced. So, while there might be slight variations in how the final
> > > solution looks like, I think the patch already deserves a:
> > > 
> > > Tested-by: Eugeniu Rosca <erosca@...adit-jv.com>
> > > 
> > > [1] Soft lockup reproduced with v5.1-rc5-10-g618d919cae2f
> > 
> > Thanks,
> > 
> > Unfortunately I do not see the patch in my inbox.
> > Would you care to repost it including the following recipients.
> > 
> > linux-pm@...r.kernel.org
> > Zhang Rui <rui.zhang@...el.com>
> > Eduardo Valentin <edubezval@...il.com>
> > linux-renesas-soc@...r.kernel.org
> > Niklas Söderlund <niklas.soderlund+renesas@...natech.se>
> > 
> > Feel free to include the suggestions made by Eugeniu above and post a v2.
> 
> There is a v2 pushed recently:
> https://patchwork.kernel.org/cover/10911999/
> ("[v2,0/2] thermal: rcar_gen3_thermal: fix IRQ issues").
> 
> It seems to include both the preparatory work suggested by Daniel
> in https://patchwork.kernel.org/patch/10895557/#22592583,
> as well as the soft lockup fix itself.

Thanks, I see v2 now.