lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 24 Apr 2019 00:59:52 +0000 From: Tao Ren <taoren@...com> To: Jakub Kicinski <jakub.kicinski@...ronome.com> CC: "David S . Miller" <davem@...emloft.net>, Maxim Mikityanskiy <maximmi@...lanox.com>, Bartosz Golaszewski <bgolaszewski@...libre.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "Samuel Mendoza-Jonas" <sam@...dozajonas.com>, Joel Stanley <joel@....id.au>, "Andrew Jeffery" <andrew@...id.au>, "openbmc@...ts.ozlabs.org" <openbmc@...ts.ozlabs.org> Subject: Re: [PATCH net 1/2] net: add eth_addr_inc in etherdevice.h On 4/23/19 4:15 PM, Jakub Kicinski wrote: > On Tue, 23 Apr 2019 22:41:56 +0000, Tao Ren wrote: >> Add eth_addr_inc function in etherdevice.h to increment MAC address. One >> of the use cases is in ncsi stack, where the host's MAC address needs to >> be incremented to get BMC's MAC address. >> >> Signed-off-by: Tao Ren <taoren@...com> > > Please squash this patch with the next one, IMHO they form a single > logical change together. Sure. Will send out updated patch soon. >> include/linux/etherdevice.h | 13 +++++++++++++ >> 1 file changed, 13 insertions(+) >> >> diff --git a/include/linux/etherdevice.h b/include/linux/etherdevice.h >> index e2f3b21cd72a..d48e3a724c54 100644 >> --- a/include/linux/etherdevice.h >> +++ b/include/linux/etherdevice.h >> @@ -448,6 +448,19 @@ static inline void eth_addr_dec(u8 *addr) >> u64_to_ether_addr(u, addr); >> } >> >> +/** >> + * eth_addr_inc - Increment the given MAC address >> + * >> + * @addr: Pointer to a six-byte array containing Ethernet address to increment > > Please see: Documentation/doc-guide/kernel-doc.rst > > Here we need: > - "()" after function name; > - no extra line between function name and argument description. Thank you for pointing it out (I didn't know the doc-guide). Given I copied the function comment from eth_addr_dec(), I will also fix the format for eth_addr_eth() then. BTW, "()" is missing from all the other functions' comment in etherdevice.h, so maybe we should fix that in a separate patch? Thanks, - Tao
Powered by blists - more mailing lists