linux-kernel - Re: [PATCH -next] crypto: atmel - remove set but not used variable 'alg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 24 Apr 2019 08:55:10 +0000
From:   <Nicolas.Ferre@...rochip.com>
To:     <yuehaibing@...wei.com>, <herbert@...dor.apana.org.au>,
        <davem@...emloft.net>, <alexandre.belloni@...tlin.com>,
        <Ludovic.Desroches@...rochip.com>, <Tudor.Ambarus@...rochip.com>
CC:     <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-crypto@...r.kernel.org>
Subject: Re: [PATCH -next] crypto: atmel - remove set but not used variable
 'alg_name'

On 24/04/2019 at 09:53, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@...wei.com>
> 
> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> drivers/crypto/atmel-tdes.c: In function 'atmel_tdes_setkey':
> drivers/crypto/atmel-tdes.c:803:14: warning: variable 'alg_name' set but not used [-Wunused-but-set-variable]
> 
> It is not used any more since
> commit 52ea3cd2917b ("crypto: atmel - Forbid 2-key 3DES in FIPS mode")
> 
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

Looks good to me:
Reviewed-by: Nicolas Ferre <nicolas.ferre@...rochip.com>

> ---
>   drivers/crypto/atmel-tdes.c | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/crypto/atmel-tdes.c b/drivers/crypto/atmel-tdes.c
> index 12492d9..fa76620 100644
> --- a/drivers/crypto/atmel-tdes.c
> +++ b/drivers/crypto/atmel-tdes.c
> @@ -800,12 +800,9 @@ static int atmel_tdes_setkey(struct crypto_ablkcipher *tfm, const u8 *key,
>   			   unsigned int keylen)
>   {
>   	struct atmel_tdes_ctx *ctx = crypto_ablkcipher_ctx(tfm);
> -	const char *alg_name;
>   	u32 flags;
>   	int err;
>   
> -	alg_name = crypto_tfm_alg_name(crypto_ablkcipher_tfm(tfm));
> -
>   	flags = crypto_ablkcipher_get_flags(tfm);
>   	err = __des3_verify_key(&flags, key);
>   	if (unlikely(err)) {
> 


-- 
Nicolas Ferre