linux-kernel - Re: [PATCH v4 1/2] thermal: rcar_gen3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190424092329.bfohle5relhof4v7@verge.net.au>
Date:   Wed, 24 Apr 2019 11:23:30 +0200
From:   Simon Horman <horms@...ge.net.au>
To:     Jiada Wang <jiada_wang@...tor.com>
Cc:     rui.zhang@...el.com, edubezval@...il.com,
        daniel.lezcano@...aro.org, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        niklas.soderlund+renesas@...natech.se, geert+renesas@...der.be,
        sergei.shtylyov@...entembedded.com, marek.vasut+renesas@...il.com,
        kuninori.morimoto.gx@...esas.com, hien.dang.eb@...esas.com,
        fabrizio.castro@...renesas.com, dien.pham.ry@...esas.com,
        biju.das@...renesas.com, erosca@...adit-jv.com,
        george_davis@...tor.com, joshua_frkuska@...tor.com
Subject: Re: [PATCH v4 1/2] thermal: rcar_gen3_thermal: fix interrupt type

On Wed, Apr 24, 2019 at 02:11:44PM +0900, Jiada Wang wrote:
> Currently IRQF_SHARED type interrupt line is allocated, but it
> is not appropriate, as the interrupt line isn't shared between
> different devices, instead IRQF_ONESHOT is the proper type.
> 
> By changing interrupt type to IRQF_ONESHOT, now irq handler is
> no longer needed, as clear of interrupt status can be done in
> threaded interrupt context.
> 
> Because IRQF_ONESHOT type interrupt line is kept disabled until
> the threaded handler has been run, so there is no need to protect
> read/write of REG_GEN3_IRQSTR with lock.
> 
> Fixes: 7d4b269776ec6 ("enable hardware interrupts for trip points")
> Signed-off-by: Jiada Wang <jiada_wang@...tor.com>


Reviewed-by: Simon Horman <horms+renesas@...ge.net.au>
Tested-by: Simon Horman <horms+renesas@...ge.net.au>