linux-kernel - Re: [PATCH] dmaengine: stm32-dma: dmaengine: stm32-dma: use platform_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20f014c3-0511-2b43-bcd2-1ca8cc700d54@st.com>
Date:   Wed, 24 Apr 2019 11:27:20 +0200
From:   Pierre Yves MORDRET <pierre-yves.mordret@...com>
To:     Fabien Dessenne <fabien.dessenne@...com>,
        Vinod Koul <vkoul@...nel.org>,
        Dan Williams <dan.j.williams@...el.com>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Alexandre Torgue <alexandre.torgue@...com>,
        <dmaengine@...r.kernel.org>,
        <linux-stm32@...md-mailman.stormreply.com>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] dmaengine: stm32-dma: dmaengine: stm32-dma: use
 platform_get_irq()

Hello

Reviewed-by: Pierre-Yves MORDRET <pierre-yves.mordret@...com>

Thanks

On 4/24/19 11:21 AM, Fabien Dessenne wrote:
> platform_get_resource(pdev, IORESOURCE_IRQ) is not recommended for
> requesting IRQ's resources, as they can be not ready yet. Using
> platform_get_irq() instead is preferred for getting IRQ even if it was
> not retrieved earlier.
> 
> Signed-off-by: Fabien Dessenne <fabien.dessenne@...com>
> ---
>  drivers/dma/stm32-dma.c | 11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/dma/stm32-dma.c b/drivers/dma/stm32-dma.c
> index ba239b5..3306818 100644
> --- a/drivers/dma/stm32-dma.c
> +++ b/drivers/dma/stm32-dma.c
> @@ -1302,13 +1302,14 @@ static int stm32_dma_probe(struct platform_device *pdev)
>  
>  	for (i = 0; i < STM32_DMA_MAX_CHANNELS; i++) {
>  		chan = &dmadev->chan[i];
> -		res = platform_get_resource(pdev, IORESOURCE_IRQ, i);
> -		if (!res) {
> -			ret = -EINVAL;
> -			dev_err(&pdev->dev, "No irq resource for chan %d\n", i);
> +		chan->irq = platform_get_irq(pdev, i);
> +		if (chan->irq < 0)  {
> +			ret = chan->irq;
> +			if (ret != -EPROBE_DEFER)
> +				dev_err(&pdev->dev,
> +					"No irq resource for chan %d\n", i);
>  			goto err_unregister;
>  		}
> -		chan->irq = res->start;
>  		ret = devm_request_irq(&pdev->dev, chan->irq,
>  				       stm32_dma_chan_irq, 0,
>  				       dev_name(chan2dev(chan)), chan);
>