linux-kernel - fs/ext4/inode.c:83:1: warning: the frame size of 1712 bytes is larger than 1024 bytes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Wed, 24 Apr 2019 18:14:45 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Kees Cook <keescook@...omium.org>
Cc:     kbuild-all@...org, linux-kernel@...r.kernel.org,
        Ard Biesheuvel <ard.biesheuvel@...aro.org>
Subject: fs/ext4/inode.c:83:1: warning: the frame size of 1712 bytes is
 larger than 1024 bytes

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   12a54b150fb5b6c2f3da932dc0e665355f8a5a48
commit: 81a56f6dcd20325607d6008f4bb560c96f4c821a gcc-plugins: structleak: Generalize to all variable types
date:   7 weeks ago
config: arm64-tizen_tm2_defconfig (attached as .config)
compiler: aarch64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout 81a56f6dcd20325607d6008f4bb560c96f4c821a
        # save the attached .config to linux build tree
        GCC_VERSION=7.2.0 make.cross ARCH=arm64 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>
All warnings (new ones prefixed by >>):

   fs/ext4/inode.c: In function 'ext4_inode_csum.isra.0':
>> fs/ext4/inode.c:83:1: warning: the frame size of 1712 bytes is larger than 1024 bytes [-Wframe-larger-than=]
    }
    ^
--
   fs/ext4/xattr.c: In function 'ext4_xattr_block_csum.isra.0':
>> fs/ext4/xattr.c:147:1: warning: the frame size of 1184 bytes is larger than 1024 bytes [-Wframe-larger-than=]
    }
    ^
--
   fs/ext4/super.c: In function 'ext4_group_desc_csum.isra.92':
>> fs/ext4/super.c:2381:1: warning: the frame size of 1184 bytes is larger than 1024 bytes [-Wframe-larger-than=]
    }
    ^

vim +83 fs/ext4/inode.c

a1d6cc56 Aneesh Kumar K.V 2008-08-19  52  
814525f4 Darrick J. Wong  2012-04-29  53  static __u32 ext4_inode_csum(struct inode *inode, struct ext4_inode *raw,
814525f4 Darrick J. Wong  2012-04-29  54  			      struct ext4_inode_info *ei)
814525f4 Darrick J. Wong  2012-04-29  55  {
814525f4 Darrick J. Wong  2012-04-29  56  	struct ext4_sb_info *sbi = EXT4_SB(inode->i_sb);
814525f4 Darrick J. Wong  2012-04-29  57  	__u32 csum;
b47820ed Daeho Jeong      2016-07-03  58  	__u16 dummy_csum = 0;
b47820ed Daeho Jeong      2016-07-03  59  	int offset = offsetof(struct ext4_inode, i_checksum_lo);
b47820ed Daeho Jeong      2016-07-03  60  	unsigned int csum_size = sizeof(dummy_csum);
814525f4 Darrick J. Wong  2012-04-29  61  
b47820ed Daeho Jeong      2016-07-03  62  	csum = ext4_chksum(sbi, ei->i_csum_seed, (__u8 *)raw, offset);
b47820ed Daeho Jeong      2016-07-03  63  	csum = ext4_chksum(sbi, csum, (__u8 *)&dummy_csum, csum_size);
b47820ed Daeho Jeong      2016-07-03  64  	offset += csum_size;
b47820ed Daeho Jeong      2016-07-03  65  	csum = ext4_chksum(sbi, csum, (__u8 *)raw + offset,
b47820ed Daeho Jeong      2016-07-03  66  			   EXT4_GOOD_OLD_INODE_SIZE - offset);
814525f4 Darrick J. Wong  2012-04-29  67  
b47820ed Daeho Jeong      2016-07-03  68  	if (EXT4_INODE_SIZE(inode->i_sb) > EXT4_GOOD_OLD_INODE_SIZE) {
b47820ed Daeho Jeong      2016-07-03  69  		offset = offsetof(struct ext4_inode, i_checksum_hi);
b47820ed Daeho Jeong      2016-07-03  70  		csum = ext4_chksum(sbi, csum, (__u8 *)raw +
b47820ed Daeho Jeong      2016-07-03  71  				   EXT4_GOOD_OLD_INODE_SIZE,
b47820ed Daeho Jeong      2016-07-03  72  				   offset - EXT4_GOOD_OLD_INODE_SIZE);
b47820ed Daeho Jeong      2016-07-03  73  		if (EXT4_FITS_IN_INODE(raw, ei, i_checksum_hi)) {
b47820ed Daeho Jeong      2016-07-03  74  			csum = ext4_chksum(sbi, csum, (__u8 *)&dummy_csum,
b47820ed Daeho Jeong      2016-07-03  75  					   csum_size);
b47820ed Daeho Jeong      2016-07-03  76  			offset += csum_size;
b47820ed Daeho Jeong      2016-07-03  77  		}
05ac5aa1 Daeho Jeong      2016-12-01  78  		csum = ext4_chksum(sbi, csum, (__u8 *)raw + offset,
05ac5aa1 Daeho Jeong      2016-12-01  79  				   EXT4_INODE_SIZE(inode->i_sb) - offset);
814525f4 Darrick J. Wong  2012-04-29  80  	}
814525f4 Darrick J. Wong  2012-04-29  81  
814525f4 Darrick J. Wong  2012-04-29  82  	return csum;
814525f4 Darrick J. Wong  2012-04-29 @83  }
814525f4 Darrick J. Wong  2012-04-29  84  

:::::: The code at line 83 was first introduced by commit
:::::: 814525f4df50a196464ce2c7abe91f693203060f ext4: calculate and verify inode checksums

:::::: TO: Darrick J. Wong <djwong@...ibm.com>
:::::: CC: Theodore Ts'o <tytso@....edu>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (39068 bytes)