linux-kernel - [PATCH] ipmi: fix slave-addr property add to ipmi platform device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 24 Apr 2019 10:34:14 +0000
From:   Kamlakant Patel <kamlakantp@...vell.com>
To:     Corey Minyard <minyard@....org>
CC:     Kamlakant Patel <kamlakantp@...vell.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "openipmi-developer@...ts.sourceforge.net" 
        <openipmi-developer@...ts.sourceforge.net>
Subject: [PATCH] ipmi: fix slave-addr property add to ipmi platform device

Remove check for p->slave_addr while adding 'slave-addr' property entry
since it can be 0.
Currently, it throws following error:
"ipmi_ssif dmi-ipmi-ssif.0: ipmi_ssif: device has no slave-addr
property"

This patch fixes the issue.

Signed-off-by: Kamlakant Patel <kamlakantp@...vell.com>
---
 drivers/char/ipmi/ipmi_plat_data.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/char/ipmi/ipmi_plat_data.c b/drivers/char/ipmi/ipmi_plat_data.c
index 8f0ca2a..2b62104 100644
--- a/drivers/char/ipmi/ipmi_plat_data.c
+++ b/drivers/char/ipmi/ipmi_plat_data.c
@@ -34,8 +34,7 @@ struct platform_device *ipmi_platform_add(const char *name, unsigned int inst,
 		p->regspacing = p->regsize;
 
 	pr[pidx++] = PROPERTY_ENTRY_U8("ipmi-type", p->type);
-	if (p->slave_addr)
-		pr[pidx++] = PROPERTY_ENTRY_U8("slave-addr", p->slave_addr);
+	pr[pidx++] = PROPERTY_ENTRY_U8("slave-addr", p->slave_addr);
 	pr[pidx++] = PROPERTY_ENTRY_U8("addr-source", p->addr_source);
 	if (p->regshift)
 		pr[pidx++] = PROPERTY_ENTRY_U8("reg-shift", p->regshift);
-- 
1.8.3.1