linux-kernel - Re: [RFC 4/6] arm64: assembler: Add macro to annotate asm function having non standard stack-frame.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c14b8e06-3916-9936-0093-6a8935019d26@arm.com>
Date:   Wed, 24 Apr 2019 11:44:26 +0100
From:   Julien Thierry <julien.thierry@....com>
To:     Raphael Gault <raphael.gault@....com>,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Cc:     jpoimboe@...hat.com, peterz@...radead.org, catalin.marinas@....com,
        will.deacon@....com
Subject: Re: [RFC 4/6] arm64: assembler: Add macro to annotate asm function
 having non standard stack-frame.

Hi Raphaël,

On 09/04/2019 14:52, Raphael Gault wrote:
> Signed-off-by: Raphael Gault <raphael.gault@....com>

Even there is not much to say, we include a commit message to explain
what the patch does and/or why we want it.

> ---
>  arch/arm64/include/asm/assembler.h | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
> 
> diff --git a/arch/arm64/include/asm/assembler.h b/arch/arm64/include/asm/assembler.h
> index 4feb6119c3c9..636a07a7eb76 100644
> --- a/arch/arm64/include/asm/assembler.h
> +++ b/arch/arm64/include/asm/assembler.h
> @@ -748,4 +748,22 @@ USER(\label, ic	ivau, \tmp2)			// invalidate I line PoU
>  .Lyield_out_\@ :
>  	.endm
>  
> +
> +#ifdef	CONFIG_STACK_VALIDATION
> +	/*
> +	 * This macro is the arm64 assembler equivalent of the
> +	 * macro STACK_FRAME_NON_STANDARD define at
> +	 * ~/include/linux/frame.h
> +	 */
> +	.macro	asm_stack_frame_non_standard	func
> +	.pushsection ".discard.func_stack_frame_non_standard"
> +	.8byte	\func
> +	.popsection
> +	.endm
> +#else
> +	.macro	asm_stack_frame_non_standard	func
> +	.endm
> +#endif
> +
> +

This can be simplified as:

	.macro asm_stack_frame_non_standard func
#ifdef CONFIG_STACK_VALIDATION
	[...]
#endif
	.endm

>  #endif	/* __ASM_ASSEMBLER_H */
> 

Cheers,

-- 
Julien Thierry