linux-kernel - Re: [PATCH] isdn: hisax: Fix misuse of %x in config.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190423.183356.286519993392180464.davem@davemloft.net>
Date:   Tue, 23 Apr 2019 18:33:56 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     huangfq.daxian@...il.com
Cc:     isdn@...ux-pingi.de, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] isdn: hisax: Fix misuse of %x in config.c

From: Fuqian Huang <huangfq.daxian@...il.com>
Date: Tue, 23 Apr 2019 10:25:28 +0800

> Pointers should be printed with %p or %px rather than
> cast to (u_long) type and printed with %lX.
> As the function seems to be for debug purpose.
> Change %lX to %px to print the pointer value.
> 
> Signed-off-by: Fuqian Huang <huangfq.daxian@...il.com>

I agree with Stephen that we should probably remove this stuff entirely
but I'll apply this for now.