linux-kernel - Re: [PATCH] drm/komeda: Mark the local functions as static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 24 Apr 2019 12:06:55 +0100
From:   Emil Velikov <emil.l.velikov@...il.com>
To:     "james qian wang (Arm Technology China)" <james.qian.wang@....com>
Cc:     Liviu Dudau <Liviu.Dudau@....com>,
        "airlied@...ux.ie" <airlied@...ux.ie>,
        Brian Starkey <Brian.Starkey@....com>,
        "maarten.lankhorst@...ux.intel.com" 
        <maarten.lankhorst@...ux.intel.com>,
        "sean@...rly.run" <sean@...rly.run>, nd <nd@....com>,
        Ayan Halder <Ayan.Halder@....com>,
        "Tiannan Zhu (Arm Technology China)" <Tiannan.Zhu@....com>,
        "Jonathan Chai (Arm Technology China)" <Jonathan.Chai@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "Julien Yin (Arm Technology China)" <Julien.Yin@....com>,
        "Yiqi Kang (Arm Technology China)" <Yiqi.Kang@....com>,
        "thomas Sun (Arm Technology China)" <thomas.Sun@....com>,
        "Lowry Li (Arm Technology China)" <Lowry.Li@....com>
Subject: Re: [PATCH] drm/komeda: Mark the local functions as static

On Wed, 24 Apr 2019 at 06:51, james qian wang (Arm Technology China)
<james.qian.wang@....com> wrote:
>
> Fix the kbuild test rebot reported warnings:
> - symbol was not declared. Should it be static?
> - missing braces around initializer
>
> Depends on:
> - https://patchwork.freedesktop.org/series/58976/
>
> Reported-by: kbuild test robot <lkp@...el.com>
> Signed-off-by: James (Qian) Wang <james.qian.wang@....com>
> ---
>  .../gpu/drm/arm/display/komeda/d71/d71_component.c    |  9 +++++----
>  drivers/gpu/drm/arm/display/komeda/komeda_crtc.c      |  4 ++--
>  drivers/gpu/drm/arm/display/komeda/komeda_dev.c       |  4 +++-
>  drivers/gpu/drm/arm/display/komeda/komeda_drv.c       |  2 +-
>  drivers/gpu/drm/arm/display/komeda/komeda_pipeline.c  |  2 +-
>  .../drm/arm/display/komeda/komeda_pipeline_state.c    | 11 ++++++-----
>  drivers/gpu/drm/arm/display/komeda/komeda_plane.c     | 10 ++++++----
>  7 files changed, 24 insertions(+), 18 deletions(-)
>
> diff --git a/drivers/gpu/drm/arm/display/komeda/d71/d71_component.c b/drivers/gpu/drm/arm/display/komeda/d71/d71_component.c
> index c56cfc2de147..031e5f305a3c 100644
> --- a/drivers/gpu/drm/arm/display/komeda/d71/d71_component.c
> +++ b/drivers/gpu/drm/arm/display/komeda/d71/d71_component.c
> @@ -391,7 +391,7 @@ static void d71_compiz_dump(struct komeda_component *c, struct seq_file *sf)
>         seq_printf(sf, "CU_USER_HIGH:\t\t0x%X\n", v[1]);
>  }
>
> -struct komeda_component_funcs d71_compiz_funcs = {
> +static struct komeda_component_funcs d71_compiz_funcs = {

Side note: Practically any piece of komeda_component_funcs and
komeda_pipeline_funcs could (and should) be constified.

-Emil