linux-kernel - Re: [PATCH] tools lib traceevent: Change tag string for error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190424080829.0043469b@gandalf.local.home>
Date:   Wed, 24 Apr 2019 08:08:29 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Leo Yan <leo.yan@...aro.org>
Cc:     Arnaldo Carvalho de Melo <acme@...hat.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tools lib traceevent: Change tag string for error

On Wed, 24 Apr 2019 09:38:02 +0800
Leo Yan <leo.yan@...aro.org> wrote:

> The traceevnt lib is used by perf tool, when execute 'perf test -v 6' it
> outputs error log on ARM64 platform:
> 
>   running test 33 '*:*'trace-cmd: No such file or directory
> 
>   [...]
> 
>   trace-cmd: Invalid argument
> 
> The trace event parsing code originally came from trace-cmd so it keeps
> the tag string "trace-cmd" for errors, this easily introduces the
> impression that perf tool launches trace-cmd command for trace event
> parsing, but in fact the related parsing is accomplished by traceevent
> lib.
> 
> This patch changes the tag string to "libtraceevent" so can avoid
> confusion and let users to be more easily to connect the error with
> traceevent lib.
> 
> Signed-off-by: Leo Yan <leo.yan@...aro.org>

Acked-by: Steven Rostedt (VMware) <rostedt@...dmis.org>

Arnaldo,

Can you pull this into your tree.

-- Steve

> ---
>  tools/lib/traceevent/parse-utils.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/lib/traceevent/parse-utils.c b/tools/lib/traceevent/parse-utils.c
> index 77e4ec6402dd..e99867111387 100644
> --- a/tools/lib/traceevent/parse-utils.c
> +++ b/tools/lib/traceevent/parse-utils.c
> @@ -14,7 +14,7 @@
>  void __vwarning(const char *fmt, va_list ap)
>  {
>  	if (errno)
> -		perror("trace-cmd");
> +		perror("libtraceevent");
>  	errno = 0;
>  
>  	fprintf(stderr, "  ");