lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 24 Apr 2019 09:48:20 +0800
From:   YueHaibing <yuehaibing@...wei.com>
To:     Russell Currey <ruscur@...sell.cc>, <paulus@...ba.org>,
        <mpe@...erman.id.au>, <mahesh@...ux.vnet.ibm.com>,
        <npiggin@...il.com>, <ganeshgr@...ux.ibm.com>, <anton@...ba.org>
CC:     <linuxppc-dev@...ts.ozlabs.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] powerpc/pseries: Use correct event modifier in
 rtas_parse_epow_errlog()



On 2019/4/24 9:29, Russell Currey wrote:
> On Tue, 2019-04-23 at 22:35 +0800, Yue Haibing wrote:
>> From: YueHaibing <yuehaibing@...wei.com>
>>
>> rtas_parse_epow_errlog() should pass 'modifier' to
>> handle_system_shutdown, because event modifier only use
>> bottom 4 bits.
>>
>> Fixes: 55fc0c561742 ("powerpc/pseries: Parse and handle EPOW
>> interrupts")
>> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> 
> Hello,
> 
> This fails to compile.
> 
> arch/powerpc/platforms/pseries/ras.c: In function
> 'rtas_parse_epow_errlog':
> arch/powerpc/platforms/pseries/ras.c:288:26: error: 'event_modifier'
> undeclared (first use in this function); did you mean 'modifier'?
>    handle_system_shutdown(event_modifier);
>                           ^~~~~~~~~~~~~~
>                           modifier

Yes, this should be 'modifier'

> 
> So yes, I assume you meant "modifier" instead of "event_modifier" as
> mentioned in your commit message.  Did you compile this before sending?

I am very sorry for this, this is not my compiled version,
I forgot to check again before sending.

> 
> (found by snowpatch)
> 
> - Russell
> 
> 
> .
> 

Powered by blists - more mailing lists