linux-kernel - Re: [PATCH v4 2/2] thermal: rcar_gen3_thermal: disable interrupt in .remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 24 Apr 2019 14:31:15 +0200
From:   Eugeniu Rosca <erosca@...adit-jv.com>
To:     Jiada Wang <jiada_wang@...tor.com>
CC:     <rui.zhang@...el.com>, <edubezval@...il.com>,
        <daniel.lezcano@...aro.org>, <linux-pm@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <horms+renesas@...ge.net.au>,
        <niklas.soderlund+renesas@...natech.se>, <geert+renesas@...der.be>,
        <sergei.shtylyov@...entembedded.com>,
        <marek.vasut+renesas@...il.com>,
        <kuninori.morimoto.gx@...esas.com>, <hien.dang.eb@...esas.com>,
        <fabrizio.castro@...renesas.com>, <dien.pham.ry@...esas.com>,
        <biju.das@...renesas.com>, <george_davis@...tor.com>,
        <joshua_frkuska@...tor.com>, Eugeniu Rosca <erosca@...adit-jv.com>,
        Eugeniu Rosca <roscaeugeniu@...il.com>
Subject: Re: [PATCH v4 2/2] thermal: rcar_gen3_thermal: disable interrupt in
 .remove

On Wed, Apr 24, 2019 at 02:11:45PM +0900, Jiada Wang wrote:
> Currently IRQ remains enabled after .remove, later if device is probed,
> IRQ is requested before .thermal_init, this may cause IRQ function be
> called before device is initialized.
> 
> this patch disables interrupt in .remove, to ensure irq function
> only be called after device is fully initialized.
> 
> Signed-off-by: Jiada Wang <jiada_wang@...tor.com>

Based on https://patchwork.kernel.org/cover/10914079/#22603533 :

Reviewed-and-Tested-by: Eugeniu Rosca <erosca@...adit-jv.com>

Thanks!

-- 
Best regards,
Eugeniu.