linux-kernel - Re: [PATCH] tools lib traceevent: Change tag string for error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190424124556.GA8948@leoy-ThinkPad-X240s>
Date:   Wed, 24 Apr 2019 20:45:56 +0800
From:   Leo Yan <leo.yan@...aro.org>
To:     Arnaldo Carvalho de Melo <acme@...hat.com>
Cc:     Steven Rostedt <rostedt@...dmis.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tools lib traceevent: Change tag string for error

On Wed, Apr 24, 2019 at 09:44:27AM -0300, Arnaldo Carvalho de Melo wrote:
> Em Wed, Apr 24, 2019 at 08:08:29AM -0400, Steven Rostedt escreveu:
> > On Wed, 24 Apr 2019 09:38:02 +0800
> > Leo Yan <leo.yan@...aro.org> wrote:
> > 
> > > The traceevnt lib is used by perf tool, when execute 'perf test -v 6' it
> > > outputs error log on ARM64 platform:
> > > 
> > >   running test 33 '*:*'trace-cmd: No such file or directory
> > > 
> > >   [...]
> > > 
> > >   trace-cmd: Invalid argument
> > > 
> > > The trace event parsing code originally came from trace-cmd so it keeps
> > > the tag string "trace-cmd" for errors, this easily introduces the
> > > impression that perf tool launches trace-cmd command for trace event
> > > parsing, but in fact the related parsing is accomplished by traceevent
> > > lib.
> > > 
> > > This patch changes the tag string to "libtraceevent" so can avoid
> > > confusion and let users to be more easily to connect the error with
> > > traceevent lib.
> > > 
> > > Signed-off-by: Leo Yan <leo.yan@...aro.org>
> > 
> > Acked-by: Steven Rostedt (VMware) <rostedt@...dmis.org>
> > 
> > Arnaldo,
> > 
> > Can you pull this into your tree.
> 
> Sure, applied.

Thanks, Steven and Arnaldo.