linux-kernel - Re: [PATCH] ARM: VDSO: Drop implicit common-page-size linker flag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <87a7gfseis.fsf@linux.ibm.com>
Date:   Wed, 24 Apr 2019 08:45:31 -0500
From:   Nathan Lynch <nathanl@...ux.ibm.com>
To:     Arnd Bergmann <arnd@...db.de>,
        Nick Desaulniers <ndesaulniers@...gle.com>
Cc:     Russell King - ARM Linux <linux@...linux.org.uk>,
        Mark Rutland <mark.rutland@....com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Dmitry Vyukov <dvyukov@...gle.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] ARM: VDSO: Drop implicit common-page-size linker flag

Arnd Bergmann <arnd@...db.de> writes:
> On Mon, Dec 10, 2018 at 11:32 PM <ndesaulniers@...gle.com> wrote:
>>
>> GNU linker's -z common-page-size's default value is based on the target
>> architecture. arch/arm/vdso/Makefile sets it to the architecture
>> default, which is implicit and redundant. Drop it.
>>
>> Link: https://lkml.kernel.org/r/20181206191231.192355-1-ndesaulniers@google.com
>> Signed-off-by: Nick Desaulniers <ndesaulniers@...gle.com>
>> ---
>
> The patch looks good to me,
>
> Acked-by: Arnd Bergmann <arnd@...db.de>
>
> Adding Nathan Lynch to Cc though for further comments, he originally
> added the Makefile flags here and might still remember why he did it.
>
> Unless Nathan objects, please add the patch to Russell's patch
> tracker.

Thanks for cc'ing me -- no objection.

Acked-by: Nathan Lynch <nathanl@...ux.ibm.com>