linux-kernel - Re: [PATCH] The patch solves the type error of the parameter “off” in syscall mmap on the ARM64 platform.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190424135015.GE14829@fuggles.cambridge.arm.com>
Date:   Wed, 24 Apr 2019 14:50:15 +0100
From:   Will Deacon <will.deacon@....com>
To:     David Howells <dhowells@...hat.com>
Cc:     Mark Rutland <mark.rutland@....com>,
        Boyang Zhou <zhouby_cn@....com>, catalin.marinas@....com,
        haozhu@...t.edu.cn, linux@...inikbrodowski.net,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-arch@...r.kernel.org, arnd@...db.de, viro@...iv.linux.org.uk,
        akpm@...ux-foundation.org
Subject: Re: [PATCH] The patch solves the type error  of the parameter “off” in
 syscall mmap on the ARM64 platform.

On Wed, Apr 24, 2019 at 09:31:28AM +0100, David Howells wrote:
> Will Deacon <will.deacon@....com> wrote:
> 
> > -		unsigned long, fd, off_t, off)
> > +		unsigned long, fd, off_t, pgoff)
> >  {
> > +	unsigned long off = pgoff;
> > +
> 
> Would loff_t be better?

I don't think so, isn't that still signed? I also think it's the same
size as off_t on arm64 (long long vs long).

Will