linux-kernel - Re: [PATCH v3 1/4] ARM: use arch_extension directive instead of arch argument

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190424141217.GC8007@atomide.com>
Date:   Wed, 24 Apr 2019 07:12:17 -0700
From:   Tony Lindgren <tony@...mide.com>
To:     Stefan Agner <stefan@...er.ch>
Cc:     arnd@...db.de, arm@...nel.org, linux@...linux.org.uk,
        ard.biesheuvel@...aro.org, robin.murphy@....com,
        nicolas.pitre@...aro.org, f.fainelli@...il.com, rjui@...adcom.com,
        sbranden@...adcom.com, bcm-kernel-feedback-list@...adcom.com,
        kgene@...nel.org, krzk@...nel.org, robh@...nel.org,
        ssantosh@...nel.org, jason@...edaemon.net, andrew@...n.ch,
        gregory.clement@...tlin.com, sebastian.hesselbarth@...il.com,
        marc.w.gonzalez@...e.fr, mans@...sr.com, ndesaulniers@...gle.com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/4] ARM: use arch_extension directive instead of arch
 argument

* Stefan Agner <stefan@...er.ch> [190423 20:20]:
> On 11.04.2019 09:54, Stefan Agner wrote:
> > The LLVM Target parser currently does not allow to specify the security
> > extension as part of -march (see also LLVM Bug 40186 [0]). When trying
> > to use Clang with LLVM's integrated assembler, this leads to build
> > errors such as this:
> >   clang-8: error: the clang compiler does not support '-Wa,-march=armv7-a+sec'
> > 
> > Use ".arch_extension sec" to enable the security extension in a more
> > portable fasion. Also make sure to use ".arch armv7-a" in case a v6/v7
> > multi-platform kernel is being built.
> > 
> > Note that this is technically not exactly the same as the old code
> > checked for availabilty of the security extension by calling as-instr.
> > However, there are already other sites which use ".arch_extension sec"
> > unconditionally, hence de-facto we need an assembler capable of
> > ".arch_extension sec" already today (arch/arm/mm/proc-v7.S). The
> > arch extension "sec" is available since binutils 2.21 according to
> > its documentation [1].
> > 
> > [0] https://bugs.llvm.org/show_bug.cgi?id=40186
> > [1] https://sourceware.org/binutils/docs-2.21/as/ARM-Options.html
> > 
> > Signed-off-by: Stefan Agner <stefan@...er.ch>
> > Acked-by: Mans Rullgard <mans@...sr.com>
> > Acked-by: Arnd Bergmann <arnd@...db.de>
> > Acked-by: Krzysztof Kozlowski <krzk@...nel.org>
> 
> Arnd, Tony,
> 
> Patch 3 and 4 got merged by Gregory. I think the other two patches are
> ready to be merged too. I think they should go in together to avoid
> merge conflicts. Tony, if you agree, can you Ack patch 2 so they can get
> merged through arm-soc?

Sure I just acked it for you.

Thanks,

Tony