linux-kernel - Re: [PATCH] rtc: stm32: manage the get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <59a465a2-99c1-caaf-97c0-b63074e38770@st.com>
Date:   Wed, 24 Apr 2019 14:51:58 +0000
From:   Amelie DELAUNAY <amelie.delaunay@...com>
To:     Fabien DESSENNE <fabien.dessenne@...com>,
        Alessandro Zummo <a.zummo@...ertech.it>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Alexandre TORGUE <alexandre.torgue@...com>,
        "linux-rtc@...r.kernel.org" <linux-rtc@...r.kernel.org>,
        "linux-stm32@...md-mailman.stormreply.com" 
        <linux-stm32@...md-mailman.stormreply.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] rtc: stm32: manage the get_irq probe defer case

On 4/24/19 2:26 PM, Fabien Dessenne wrote:
> Manage the -EPROBE_DEFER error case for the wake IRQ.
> 
> Signed-off-by: Fabien Dessenne <fabien.dessenne@...com>

Acked-by: Amelie Delaunay <amelie.delaunay@...com>

> ---
>   drivers/rtc/rtc-stm32.c | 9 ++++++---
>   1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/rtc/rtc-stm32.c b/drivers/rtc/rtc-stm32.c
> index c5908cf..8e6c9b3 100644
> --- a/drivers/rtc/rtc-stm32.c
> +++ b/drivers/rtc/rtc-stm32.c
> @@ -788,11 +788,14 @@ static int stm32_rtc_probe(struct platform_device *pdev)
>   	ret = device_init_wakeup(&pdev->dev, true);
>   	if (rtc->data->has_wakeirq) {
>   		rtc->wakeirq_alarm = platform_get_irq(pdev, 1);
> -		if (rtc->wakeirq_alarm <= 0)
> -			ret = rtc->wakeirq_alarm;
> -		else
> +		if (rtc->wakeirq_alarm > 0) {
>   			ret = dev_pm_set_dedicated_wake_irq(&pdev->dev,
>   							    rtc->wakeirq_alarm);
> +		} else {
> +			ret = rtc->wakeirq_alarm;
> +			if (rtc->wakeirq_alarm == -EPROBE_DEFER)
> +				goto err;
> +		}
>   	}
>   	if (ret)
>   		dev_warn(&pdev->dev, "alarm can't wake up the system: %d", ret);
>