linux-kernel - Re: [PATCH] chardev: set variable ret to -EBUSY before checking minor range overlap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190425194946.GA15196@kroah.com>
Date:   Thu, 25 Apr 2019 21:49:46 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Chengguang Xu <cgxu519@....com>
Cc:     dan.carpenter@...cle.com, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] chardev: set variable ret to -EBUSY before checking
 minor range overlap

On Fri, Apr 05, 2019 at 09:53:06PM +0800, Chengguang Xu wrote:
> When allocating dynamic major, the minor range overlap check
> in __register_chrdev_region() will not fail, so actually
> there is no real case to passing non negative error code to
> caller. However, set variable ret to -EBUSY before chekcking
> minor range overlap will avoid false-positive warning from
> code analyzing tool(like Smatch) and also make the code more
> easy to understand.
> 
> Suggested-by: Dan Carpenter <dan.carpenter@...cle.com>
> Signed-off-by: Chengguang Xu <cgxu519@....com>
> ---
>  fs/char_dev.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

What tree was this patch made against?  I can't seem to apply it
anywhere :(

Please fix up and resend.

thanks,

greg k-h