linux-kernel - Re: [PATCH v1 00/14] usb: dwc2: Fix and improve power saving modes.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 25 Apr 2019 13:12:23 -0700
From:   Doug Anderson <dianders@...omium.org>
To:     Artur Petrosyan <Arthur.Petrosyan@...opsys.com>
Cc:     Felipe Balbi <balbi@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Minas Harutyunyan <Minas.Harutyunyan@...opsys.com>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        John Youn <John.Youn@...opsys.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1 00/14] usb: dwc2: Fix and improve power saving modes.

Hi,

On Thu, Apr 25, 2019 at 7:01 AM Artur Petrosyan
<Arthur.Petrosyan@...opsys.com> wrote:
>
> Hi,
>
> On 4/25/2019 16:43, Felipe Balbi wrote:
> > Artur Petrosyan <Arthur.Petrosyan@...opsys.com> writes:
> >> This patch set, fixes and improves partial power down and hibernation power
> >> saving modes. Also, adds support for entering/exiting hibernation by
> >> system issued suspend/resume.
> >>
> >> This series contains patches which were submitted to LKML. However, a part
> >> of those patches didn't reach to LKML because of local issue related to
> >> smtp server.
> >>
> >> The patches which reached to LKML are:
> >>
> >> - usb: dwc2: Add part. power down exit from dwc2_conn_id_status_change().
> >> - usb: dwc2: Add port conn. sts. checking in _dwc2_hcd_resume() function.
> >> - usb: dwc2: Fix suspend state in host mode for partial power down.
> >> - usb: dwc2: Fix wakeup detected and session request interrupt handlers.
> >> - usb: dwc2: Add descriptive debug messages for Partial Power Down mode.
> >> - usb: dwc2: Fix dwc2_restore_device_registers() function.
> >>
> >> The patches which didn't reach to LKML are:
> >>
> >> - usb: dwc2: Add enter/exit hibernation from system issued suspend/resume
> >> - usb: dwc2: Clear GINTSTS_RESTOREDONE bit after restore is generated.
> >> - usb: dwc2: Clear fifo_map when resetting core.
> >> - usb: dwc2: Allow exiting hibernation from gpwrdn rst detect
> >> - usb: dwc2: Fix hibernation between host and device modes.
> >> - usb: dwc2: Update dwc2_handle_usb_suspend_intr function.
> >> - usb: dwc2: Add default param to control power optimization.
> >> - usb: dwc2: Reset DEVADDR after exiting gadget hibernation.
> >>
> >> Submitting all of the patches together in this version.
> >>
> >> Changes from V0:
> >>   - Replaced 1 with DWC2_POWER_DOWN_PARAM_PARTIAL in commit
> >>     "9eed02b9fe96 usb: dwc2: Fix wakeup detected and session request
> >>     interrupt handlers.
> >>
> >>
> >> Artur Petrosyan (14):
> >>    usb: dwc2: Fix dwc2_restore_device_registers() function.
> >>    usb: dwc2: Add descriptive debug messages for Partial Power Down mode.
> >>    usb: dwc2: Fix wakeup detected and session request interrupt handlers.
> >>    usb: dwc2: Fix suspend state in host mode for partial power down.
> >>    usb: dwc2: Add port conn. sts. checking in _dwc2_hcd_resume()
> >>      function.
> >>    usb: dwc2: Add part. power down exit from
> >>      dwc2_conn_id_status_change().
> >>    usb: dwc2: Reset DEVADDR after exiting gadget hibernation.
> >>    usb: dwc2: Add default param to control power optimization.
> >>    usb: dwc2: Update dwc2_handle_usb_suspend_intr function.
> >>    usb: dwc2: Fix hibernation between host and device modes.
> >>    usb: dwc2: Allow exiting hibernation from gpwrdn rst detect
> >>    usb: dwc2: Clear fifo_map when resetting core.
> >>    usb: dwc2: Clear GINTSTS_RESTOREDONE bit after restore is generated.
> >>    usb: dwc2: Add enter/exit hibernation from system issued
> >>      suspend/resume
> >
> > patches don't apply.
> >
>
> Do we need to wait for Minas's acknowledge or there is problem related
> to the patches?

It looks like the problem is that my patches won the race and Felipe
applied them before yours.  Thus, presumably, it'll be up to you to
rebase your patches atop mine and re-submit.  Specifically, you can
do:

git remote add linux_usb_balbi
git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git
git fetch linux_usb_balbi
git checkout linux_usb_balbi/testing/next

If you do that and then try to apply your patches you'll find that
they no longer apply.  AKA try running:

for patch in 10909749 10909737 10909739 10909745 10909533 \
   10909531 10909747 10909535 10909523 10909741 10909525 \
   10909751 10909527 10909743; do
  curl -L https://patchwork.kernel.org/patch/${patch}/mbox | git am
done

You'll see:

> Applying: usb: dwc2: Fix wakeup detected and session request interrupt handlers.
> error: patch failed: drivers/usb/dwc2/core_intr.c:435
> error: drivers/usb/dwc2/core_intr.c: patch does not apply
> Patch failed at 0001 usb: dwc2: Fix wakeup detected and session request interrupt handlers.

NOTE: before reposting it might be a good idea to apply the last 3
patches in my series as per [1] before sending up your series.  Since
Felipe has already applied patches #1 and #2 in that series presumably
he'll also apply #3 - #5.

I know it'a also up to me to try testing our your patches.  It's still
on my list to give it a shot...

[1] https://lkml.kernel.org/r/CAD=FV=WA07+gUkVvsikN=iDHZLUJQtzjkKtiBHAEDw4gLNWY7w@mail.gmail.com

P.S: It's helpful if you CC LKML on patches and discussions about
them.  That allows the magic "permalink via message ID" on
lkml.kernel.org and also allows your patches to be found on
lore.kernel.org/patchwork/

-Doug