linux-kernel - Re: [PATCH v3 7/7] clk: at91: add sam9x60 pmc driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <155622589096.15276.8583738150370510787@swboyd.mtv.corp.google.com>
Date:   Thu, 25 Apr 2019 13:58:10 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Alexandre Belloni <alexandre.belloni@...tlin.com>
Cc:     Nicolas Ferre <nicolas.ferre@...rochip.com>,
        Claudiu Beznea <claudiu.beznea@...rochip.com>,
        Michael Turquette <mturquette@...libre.com>,
        linux-clk@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 7/7] clk: at91: add sam9x60 pmc driver

Quoting Alexandre Belloni (2019-04-25 13:31:39)
> On 25/04/2019 12:38:55-0700, Stephen Boyd wrote:
> > Quoting Alexandre Belloni (2019-04-02 05:50:56)
> > > diff --git a/drivers/clk/at91/sam9x60.c b/drivers/clk/at91/sam9x60.c
> > > new file mode 100644
> > > index 000000000000..22bf51c55bdc
> > > --- /dev/null
> > > +++ b/drivers/clk/at91/sam9x60.c
> > > @@ -0,0 +1,307 @@
> > > +// SPDX-License-Identifier: GPL-2.0
> > > +#include <linux/clk-provider.h>
> > > +#include <linux/mfd/syscon.h>
> > > +#include <linux/slab.h>
> > > +
> > > +#include <dt-bindings/clock/at91.h>
> > > +
> > > +#include "pmc.h"
> > > +
> > > +DEFINE_SPINLOCK(pmc_pll_lock);
> > > +
> > > +static const struct clk_master_characteristics mck_characteristics = {
> > > +       .output = { .min = 140000000, .max = 200000000 },
> > > +       .divisors = { 1, 2, 4, 3 },
> > > +       .have_div3_pres = 1,
> > > +};
> > > +
> > > +static const struct clk_master_layout sam9x60_master_layout = {
> > > +       .mask = 0x373,
> > > +       .pres_shift = 4,
> > > +       .offset = 0x28,
> > > +};
> > > +
> > > +static struct clk_range plla_outputs[] = {
> > 
> > const?
> > 
> 
> Right, can you fix that up or should I send a new version?
> 

I can fix it.

> > > +       { .min = 300000000, .max = 600000000 },
> > > +};
> > [...]
> > > +
> > > +}
> > > +
> > > +CLK_OF_DECLARE_DRIVER(sam9x60_pmc, "microchip,sam9x60-pmc", sam9x60_pmc_setup);
> > > -- 
> > 
> > Can't be platform device?
> > 
> 
> IIRC two clocks are used by the clocksource and having it as a platform
> device make the clocksource driver fail with -EPROBE_DEFER.
> 

Ok. I'll add a comment in the driver. It needs to be
CLK_OF_DECLARE_DRIVER() because it's used somewhere else too? Or it can
be CLK_OF_DECLARE() instead?