linux-kernel - Re: [Freedreno] [PATCH] drm/msm: check for equals 0 only

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7dc496f1663fa788977b8b00bce9d695@codeaurora.org>
Date:   Thu, 25 Apr 2019 15:52:50 -0700
From:   Abhinav Kumar <abhinavk@...eaurora.org>
To:     Nicholas Mc Guire <hofrat@...dl.org>
Cc:     Rob Clark <robdclark@...il.com>, freedreno@...ts.freedesktop.org,
        Archit Taneja <architt@...eaurora.org>,
        David Airlie <airlied@...ux.ie>, linux-arm-msm@...r.kernel.org,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        Jordan Crouse <jcrouse@...eaurora.org>,
        Sibi Sankar <sibis@...eaurora.org>,
        Daniel Vetter <daniel@...ll.ch>,
        Chandan Uddaraju <chandanu@...eaurora.org>,
        Sean Paul <sean@...rly.run>, Daniel Mack <daniel@...que.org>
Subject: Re: [Freedreno] [PATCH] drm/msm: check for equals 0 only

On 2019-04-25 07:03, Nicholas Mc Guire wrote:
> wait_for_completion_timeout() returns 0 on timeout and aleast 1 
> otherwise
> so checking for < makes no sense here.
> 
> Signed-off-by: Nicholas Mc Guire <hofrat@...dl.org>
Reviewed-by: Abhinav Kumar <abhinavk@...eaurora.org>
> ---
> 
> Problem located with an experimental coccinelle script
> 
> While this check does no harm in this form - it should be fixed anyway
> to comply with the API see: kernel/sched/completion.c
> 
> Also noticed that get_maintainer.pl will not list 
> linux-kernel@...r.kernel.org
> when run on drivers/gpu/drm/msm/dsi/dsi_host.c - is that intentional ?
> 
> Patch was compile-tested with: qcom_defconfig (implies DRM_MSM_DSI=y)
> 
> Patch is against v5.1-rc6 (localversion-next is next-20190424)
> 
>  drivers/gpu/drm/msm/dsi/dsi_host.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c
> b/drivers/gpu/drm/msm/dsi/dsi_host.c
> index 610183d..dc16067 100644
> --- a/drivers/gpu/drm/msm/dsi/dsi_host.c
> +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c
> @@ -1049,7 +1049,7 @@ static void dsi_wait4video_done(struct
> msm_dsi_host *msm_host)
>  	ret = wait_for_completion_timeout(&msm_host->video_comp,
>  			msecs_to_jiffies(70));
> 
> -	if (ret <= 0)
> +	if (ret == 0)
>  		DRM_DEV_ERROR(dev, "wait for video done timed out\n");
> 
>  	dsi_intr_ctrl(msm_host, DSI_IRQ_MASK_VIDEO_DONE, 0);