linux-kernel - Re: [PATCH 3/5] input: edt-ft5x06 - Call devm_of_device_links

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <769d2c1e-8a33-d4fe-a3d9-6de4772b67d4@st.com>
Date:   Thu, 25 Apr 2019 07:22:03 +0000
From:   Benjamin GAIGNARD <benjamin.gaignard@...com>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>
CC:     "rafael.j.wysocki@...el.com" <rafael.j.wysocki@...el.com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "hadess@...ess.net" <hadess@...ess.net>,
        "frowand.list@...il.com" <frowand.list@...il.com>,
        "m.felsch@...gutronix.de" <m.felsch@...gutronix.de>,
        "agx@...xcpu.org" <agx@...xcpu.org>,
        "Yannick FERTRE" <yannick.fertre@...com>,
        "arnd@...db.de" <arnd@...db.de>,
        "linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-stm32@...md-mailman.stormreply.com" 
        <linux-stm32@...md-mailman.stormreply.com>,
        "broonie@...nel.org" <broonie@...nel.org>
Subject: Re: [PATCH 3/5] input: edt-ft5x06 - Call devm_of_device_links_add()
 to create links


On 4/25/19 12:52 AM, Dmitry Torokhov wrote:
> Hi Benjamin,
>
> On Wed, Apr 24, 2019 at 12:19:11PM +0200, Benjamin Gaignard wrote:
>> From: Yannick FertrÃ© <yannick.fertre@...com>
>>
>> Add a call to devm_of_device_links_add() to create links with suppliers
>> at probe time.
>>
>> Signed-off-by: Yannick Fertré <yannick.fertre@...com>
>> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@...com>
>> ---
>>   drivers/input/touchscreen/edt-ft5x06.c | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/input/touchscreen/edt-ft5x06.c b/drivers/input/touchscreen/edt-ft5x06.c
>> index 702bfda7ee77..ac9f7e85efb0 100644
>> --- a/drivers/input/touchscreen/edt-ft5x06.c
>> +++ b/drivers/input/touchscreen/edt-ft5x06.c
>> @@ -1167,6 +1167,8 @@ static int edt_ft5x06_ts_probe(struct i2c_client *client,
>>   
>>   	i2c_set_clientdata(client, tsdata);
>>   
>> +	devm_of_device_links_add(&client->dev);
>> +
> This seems pretty generic action and I believe it should be done in
> generic code, either bus (i2c, spi, etc), or in device core.
It is done (or could be done) in most of the buses or framework (like 
for regulator)
but I think that adding it in device core add a device-tree node parsing 
for all the
drivers while only a few of them will really need this feature. That why 
I have put the
call here.

Benjamin
>
> Thanks.
>