linux-kernel - [PATCH] HID: logitech-dj: Fix build error without CONFIG_USB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190425073942.36980-1-yuehaibing@huawei.com>
Date:   Thu, 25 Apr 2019 15:39:42 +0800
From:   Yue Haibing <yuehaibing@...wei.com>
To:     <jikos@...nel.org>, <benjamin.tissoires@...hat.com>,
        <hdegoede@...hat.com>
CC:     <linux-kernel@...r.kernel.org>, <linux-input@...r.kernel.org>,
        YueHaibing <yuehaibing@...wei.com>
Subject: [PATCH] HID: logitech-dj: Fix build error without CONFIG_USB_HID

From: YueHaibing <yuehaibing@...wei.com>

During randconfig builds, I occasionally run into an invalid configuration

drivers/hid/hid-logitech-dj.o: In function `logi_dj_probe':
hid-logitech-dj.c:(.text+0x32dc): undefined reference to `usb_hid_driver'

This is because CONFIG_USB_HID is not set, So this
patch selects it.

Reported-by: Hulk Robot <hulkci@...wei.com>
Fixes: da12b224b7d5 ("HID: logitech-dj: deal with some KVMs adding an extra interface to the usbdev")
Signed-off-by: YueHaibing <yuehaibing@...wei.com>
---
 drivers/hid/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
index 76d8206..c3c390c 100644
--- a/drivers/hid/Kconfig
+++ b/drivers/hid/Kconfig
@@ -521,6 +521,7 @@ config HID_LOGITECH
 
 config HID_LOGITECH_DJ
 	tristate "Logitech Unifying receivers full support"
+	depends on USB_HID
 	depends on HIDRAW
 	depends on HID_LOGITECH
 	select HID_LOGITECH_HIDPP
-- 
2.7.4