linux-kernel - Re: [PATCH] quota: fix wrong indentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 25 Apr 2019 11:59:55 +0200
From:   Jan Kara <jack@...e.cz>
To:     Chengguang Xu <cgxu519@....com>
Cc:     jack@...e.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] quota: fix wrong indentation

On Fri 19-04-19 13:46:01, Chengguang Xu wrote:
> We need to check return code only when calling ->read_dqblk(),
> so fix it properly.
> 
> Signed-off-by: Chengguang Xu <cgxu519@....com>

Thanks. Added to my tree.

								Honza

> ---
>  fs/quota/dquot.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/fs/quota/dquot.c b/fs/quota/dquot.c
> index fc20e06c56ba..934b8f3f9e57 100644
> --- a/fs/quota/dquot.c
> +++ b/fs/quota/dquot.c
> @@ -424,10 +424,11 @@ int dquot_acquire(struct dquot *dquot)
>  	struct quota_info *dqopt = sb_dqopt(dquot->dq_sb);
> 
>  	mutex_lock(&dquot->dq_lock);
> -	if (!test_bit(DQ_READ_B, &dquot->dq_flags))
> +	if (!test_bit(DQ_READ_B, &dquot->dq_flags)) {
>  		ret = dqopt->ops[dquot->dq_id.type]->read_dqblk(dquot);
> -	if (ret < 0)
> -		goto out_iolock;
> +		if (ret < 0)
> +			goto out_iolock;
> +	}
>  	/* Make sure flags update is visible after dquot has been filled */
>  	smp_mb__before_atomic();
>  	set_bit(DQ_READ_B, &dquot->dq_flags);
> --
> 2.20.1
> 
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR