linux-kernel - Re: linux-next: Fixes tags need some work in the hid tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 25 Apr 2019 16:16:17 +0200
From:   Benjamin Tissoires <benjamin.tissoires@...hat.com>
To:     Stephen Rothwell <sfr@...b.auug.org.au>
Cc:     Jiri Kosina <jikos@...nel.org>,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: linux-next: Fixes tags need some work in the hid tree

Hi Stephen,

On Thu, Apr 25, 2019 at 3:34 PM Stephen Rothwell <sfr@...b.auug.org.au> wrote:
>
> Hi all,
>
> In commit
>
>   39b3c3a5fbc5 ("HID: input: fix assignment of .value")
>
> Fixes tag
>
>   Fixes: 2dc702c991e377 ("HID: input: use the Resolution Multiplier for
>
> has these problem(s):
>
>   - Subject has leading but no trailing parentheses
>   - Subject has leading but no trailing quotes
>
> In commit
>
>   d43c17ead879 ("HID: input: make sure the wheel high resolution multiplier is set")
>
> Fixes tag
>
>   Fixes: 2dc702c991e377 ("HID: input: use the Resolution Multiplier for
>
> has these problem(s):
>
>   - Subject has leading but no trailing parentheses
>   - Subject has leading but no trailing quotes
>
> Please do not aplit Fixes tags over more than one line.
>

Sorry for that, these are my commits.

I just re-read the doc, and indeed, we are not supposed to trim or
split the commit title. I'll be more careful next time.

Also, can't we add these requirements in checkpatch?

Cheers,
Benjamin