linux-kernel - Re: [PATCH] fs/quota: erase unused but set variable warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190425150558.GA32215@quack2.suse.cz>
Date:   Thu, 25 Apr 2019 17:05:58 +0200
From:   Jan Kara <jack@...e.cz>
To:     Jiang Biao <benbjiang@...cent.com>
Cc:     jack@...e.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fs/quota: erase unused but set variable warning

On Wed 24-04-19 08:58:57, Jiang Biao wrote:
> Local variable *reserved* of remove_dquot_ref() is only used if
> define CONFIG_QUOTA_DEBUG, but not ebraced in CONFIG_QUOTA_DEBUG
> macro, which leads to unused-but-set-variable warning when compiling.
> 
> This patch ebrace it into CONFIG_QUOTA_DEBUG macro like what is done
> in add_dquot_ref().
> 
> Signed-off-by: Jiang Biao <benbjiang@...cent.com>

Thanks. I've added the patch to my tree.

								Honza

> ---
>  fs/quota/dquot.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/fs/quota/dquot.c b/fs/quota/dquot.c
> index fc20e06c56ba..14ee4c6deba1 100644
> --- a/fs/quota/dquot.c
> +++ b/fs/quota/dquot.c
> @@ -1049,7 +1049,9 @@ static void remove_dquot_ref(struct super_block *sb, int type,
>  		struct list_head *tofree_head)
>  {
>  	struct inode *inode;
> +#ifdef CONFIG_QUOTA_DEBUG
>  	int reserved = 0;
> +#endif
>  
>  	spin_lock(&sb->s_inode_list_lock);
>  	list_for_each_entry(inode, &sb->s_inodes, i_sb_list) {
> @@ -1061,8 +1063,10 @@ static void remove_dquot_ref(struct super_block *sb, int type,
>  		 */
>  		spin_lock(&dq_data_lock);
>  		if (!IS_NOQUOTA(inode)) {
> +#ifdef CONFIG_QUOTA_DEBUG
>  			if (unlikely(inode_get_rsv_space(inode) > 0))
>  				reserved = 1;
> +#endif
>  			remove_inode_dquot_ref(inode, type, tofree_head);
>  		}
>  		spin_unlock(&dq_data_lock);
> -- 
> 2.17.2 (Apple Git-113)
> 
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR