linux-kernel - Re: [v3 1/2] device-dax: fix memory and resource leak if hotplug fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <67dba1e2-155c-f572-81dd-a6d589d0e8a5@intel.com>
Date:   Thu, 25 Apr 2019 11:32:15 -0700
From:   Dave Hansen <dave.hansen@...el.com>
To:     Pavel Tatashin <pasha.tatashin@...een.com>, jmorris@...ei.org,
        sashal@...nel.org, linux-kernel@...r.kernel.org,
        linux-mm@...ck.org, linux-nvdimm@...ts.01.org,
        akpm@...ux-foundation.org, mhocko@...e.com,
        dave.hansen@...ux.intel.com, dan.j.williams@...el.com,
        keith.busch@...el.com, vishal.l.verma@...el.com,
        dave.jiang@...el.com, zwisler@...nel.org, thomas.lendacky@....com,
        ying.huang@...el.com, fengguang.wu@...el.com, bp@...e.de,
        bhelgaas@...gle.com, baiyaowei@...s.chinamobile.com, tiwai@...e.de,
        jglisse@...hat.com, david@...hat.com
Subject: Re: [v3 1/2] device-dax: fix memory and resource leak if hotplug
 fails

On 4/25/19 10:54 AM, Pavel Tatashin wrote:
>  	rc = add_memory(numa_node, new_res->start, resource_size(new_res));
> -	if (rc)
> +	if (rc) {
> +		release_resource(new_res);
> +		kfree(new_res);
>  		return rc;
> +	}

Looks good to me:

Reviewed-by: Dave Hansen <dave.hansen@...el.com>