linux-kernel - Re: [PATCH v2 2/3] input: keyboard: gpio_keys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGngYiWGpCeJfBQraTidHLDGjNWsUkp0g4HD=0JRUwT8mX8txg@mail.gmail.com>
Date:   Fri, 26 Apr 2019 16:16:19 -0400
From:   Sven Van Asbroeck <thesven73@...il.com>
To:     "Enrico Weigelt, metux IT consult" <info@...ux.net>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        linux-input@...r.kernel.org
Subject: Re: [PATCH v2 2/3] input: keyboard: gpio_keys_polled: use gpio lookup table

On Fri, Apr 26, 2019 at 3:03 PM Enrico Weigelt, metux IT consult
<info@...ux.net> wrote:
>
> +static struct gpio_desc *gpio_keys_polled_get_gpiod_fwnode(
> +       struct device *dev,
> +       int idx,
> +       const char *desc)
> +{
> +       struct gpio_desc *gpiod;
> +       struct fwnode_handle *child;
> +       int x;
> +
> +       /* get the idx'th child node */
> +       child = device_get_next_child_node(dev, NULL);
> +       while (child && x) {
> +               child = device_get_next_child_node(dev, child);
> +               x--;
> +       }

x is uninitialized here.