linux-kernel - Re: [PATCH v3 7/7] clk: at91: add sam9x60 pmc driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <155631617779.168659.28330983552532693@swboyd.mtv.corp.google.com>
Date:   Fri, 26 Apr 2019 15:02:57 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Alexandre Belloni <alexandre.belloni@...tlin.com>
Cc:     Nicolas Ferre <nicolas.ferre@...rochip.com>,
        Claudiu Beznea <claudiu.beznea@...rochip.com>,
        Michael Turquette <mturquette@...libre.com>,
        linux-clk@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 7/7] clk: at91: add sam9x60 pmc driver

Quoting Alexandre Belloni (2019-04-26 14:06:51)
> On 25/04/2019 14:20:41-0700, Stephen Boyd wrote:
> > 
> > Hmm I was just confused it seems. If you don't have two devices probing
> > the same DT node with this compatible string then I think it can just be
> > CLK_OF_DECLARE(). I was thinking that you were running into some sort of
> > issue where the other driver using this same compatible couldn't probe.
> > 
> 
> I tried separating it into two initializations and do as much as
> possible in the platform driver but because the TCB clocks are
> peripheral clocks that depend on most of the other ones, I didn't find
> it convenient. This can safely be changed to CLK_OF_DECLARE. I can send
> v4 if you want. This should probably be changed for the other drivers
> too.

I've fixed it locally, just haven't pushed it out. If you have other
drivers that should be using CLK_OF_DECLARE then feel free to send a
patch for it.