linux-kernel - Re: [PATCH net-next v2 13/20] net: ethernet: ti: davinci_mdio: use devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190426221232.GF23059@lunn.ch>
Date:   Sat, 27 Apr 2019 00:12:32 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Grygorii Strashko <grygorii.strashko@...com>
Cc:     netdev@...r.kernel.org,
        Ilias Apalodimas <ilias.apalodimas@...aro.org>,
        "David S . Miller" <davem@...emloft.net>,
        Ivan Khoronzhuk <ivan.khoronzhuk@...aro.org>,
        Florian Fainelli <f.fainelli@...il.com>,
        Sekhar Nori <nsekhar@...com>, linux-kernel@...r.kernel.org,
        linux-omap@...r.kernel.org, Murali Karicheri <m-karicheri2@...com>
Subject: Re: [PATCH net-next v2 13/20] net: ethernet: ti: davinci_mdio: use
 devm_ioremap()

On Fri, Apr 26, 2019 at 08:12:35PM +0300, Grygorii Strashko wrote:
> The Davinci MDIO in most of the case implemented as module inside of TI
> CPSW subsystem and fully depends on CPSW to be enabled, but historically
> it's implemented as separate Platform device/driver and defined in DT files
> in two ways:
> - as standalone node
> - as child node of CPSW subsystem.
> 
> In later case it's required to split CPSW subsystem "reg" property to
> exclude MDIO I/O range which is not useful.
> 
> Hence, replace devm_ioremap_resource() with devm_ioremap() to allow define
> full I/O range in parent CPSW subsystem without spliting.
> 
> Signed-off-by: Grygorii Strashko <grygorii.strashko@...com>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew