linux-kernel - Re: [alsa-devel] [PATCH] ASoC: fsl_sai: Add missing return 0 in remove()

Open Source and information security mailing list archives

Message-ID: <CAEnQRZCV7mnBmUFiC2pVz4ndo6a0L1eF8pAuiOO5OBTayXt=SA@mail.gmail.com>
Date:   Fri, 26 Apr 2019 08:19:14 +0300
From:   Daniel Baluta <daniel.baluta@...il.com>
To:     Nicolin Chen <nicoleotsuka@...il.com>
Cc:     Mark Brown <broonie@...nel.org>,
        Daniel Baluta <daniel.baluta@....com>, sfr@...b.auug.org.au,
        Linux-ALSA <alsa-devel@...a-project.org>,
        Timur Tabi <timur@...nel.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        linuxppc-dev@...ts.ozlabs.org, Xiubo Li <Xiubo.Lee@...il.com>,
        Takashi Iwai <tiwai@...e.com>,
        Fabio Estevam <festevam@...il.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [alsa-devel] [PATCH] ASoC: fsl_sai: Add missing return 0 in remove()

On Fri, Apr 26, 2019 at 6:22 AM Nicolin Chen <nicoleotsuka@...il.com> wrote:
>
> Build warning being reported:
>     sound/soc/fsl/fsl_sai.c: In function 'fsl_sai_remove':
>     sound/soc/fsl/fsl_sai.c:921:1: warning: no return statement in
>     function returning non-void [-Wreturn-type]
>
> So this patch just adds a "return 0" to fix it.
>
> Fixes: 812ad463e089 ("ASoC: fsl_sai: Add support for runtime pm")
> Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>
> Signed-off-by: Nicolin Chen <nicoleotsuka@...il.com>

Reviewed-by: Daniel Baluta <daniel.baluta@....com>

Thanks Nicolin!

> ---
>  sound/soc/fsl/fsl_sai.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/sound/soc/fsl/fsl_sai.c b/sound/soc/fsl/fsl_sai.c
> index 26c27dc..8593269 100644
> --- a/sound/soc/fsl/fsl_sai.c
> +++ b/sound/soc/fsl/fsl_sai.c
> @@ -918,6 +918,8 @@ static int fsl_sai_probe(struct platform_device *pdev)
>  static int fsl_sai_remove(struct platform_device *pdev)
>  {
>         pm_runtime_disable(&pdev->dev);
> +
> +       return 0;
>  }
>
>  static const struct of_device_id fsl_sai_ids[] = {
> --
> 2.7.4
>
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@...a-project.org
> https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives