linux-kernel - Re: [PATCH v2 00/15] add ecspi ERR009165 for i.mx6/7 soc family

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1556266779.2584.15.camel@pengutronix.de>
Date:   Fri, 26 Apr 2019 10:19:39 +0200
From:   Lucas Stach <l.stach@...gutronix.de>
To:     Robin Gong <yibin.gong@....com>,
        "broonie@...nel.org" <broonie@...nel.org>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "festevam@...il.com" <festevam@...il.com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "u.kleine-koenig@...gutronix.de" <u.kleine-koenig@...gutronix.de>,
        "plyatov@...il.com" <plyatov@...il.com>,
        "dan.j.williams@...el.com" <dan.j.williams@...el.com>,
        "catalin.marinas@....com" <catalin.marinas@....com>,
        "will.deacon@....com" <will.deacon@....com>
Cc:     "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-spi@...r.kernel.org" <linux-spi@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "dmaengine@...r.kernel.org" <dmaengine@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v2 00/15] add ecspi ERR009165 for i.mx6/7 soc family

Hi Robin,

Am Freitag, den 26.04.2019, 08:05 +0000 schrieb Robin Gong:
>   There is ecspi ERR009165 on i.mx6/7 soc family, which cause FIFO
> transfer to be send twice in DMA mode. Please get more information from:
> https://www.nxp.com/docs/en/errata/IMX6DQCE.pdf. The workaround is adding
> new sdma ram script which works in XCH  mode as PIO inside sdma instead
> of SMC mode, meanwhile, 'TX_THRESHOLD' should be 0.

I would like to have a more in-depth explanation about how this new RAM
script differs from the existing ROM script and the changes to the
state transitions.

>   The issue should be exist on all legacy i.mx6/7 soc family before i.mx6ul,
> NXP fix this design issue from i.mx6ul, so newer chips such as i.mx6ull/
> i.mx8mq/i.mx8mm, don't need this workaroud anymore. This patch set
> add new 'fsl,imx6ul-ecspi' for ecspi driver and 'ecspi_fixed' in sdma
> driver to choose if need errata or not.
>   The first two reverted patches should be the same issue, though, it
> seems 'fixed' by changing to other shp script. Hope Sean or Sascha could
> have the chance to test this patch set if could fix their issues.
>   Besides, enable sdma support for i.mx8mm/8mq and fix ecspi1 not work
> on i.mx8mm because the event id is zero.
> 
> PS:
>  Please get sdma firmware from below linux-firmware and copy it to your
> local rootfs /lib/firmware/imx/sdma.
> https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/tree/imx/sdma

This is not an option as long as the SDMA RAM firmware breaks the
mainline serial DMA support. Please provide a fixed SDMA RAM firmware
that doesn't replace the ROM serial script, as that one is totally
fine.

Regards,
Lucas

> v2:
>   1. add commit log for reverted patches.
>   2. add comment for 'ecspi_fixed' in sdma driver.
>   3. add 'fsl,imx6sll-ecspi' compatible instead of 'fsl,imx6ul-ecspi'
>      rather than remove.
> 
> 
> Robin Gong (15):
>   Revert "ARM: dts: imx6q: Use correct SDMA script for SPI5 core"
>   Revert "ARM: dts: imx6: Use correct SDMA script for SPI cores"
>   Revert "dmaengine: imx-sdma: refine to load context only once"
>   dmaengine: imx-sdma: remove dupilicated sdma_load_context
>   dma: engine: imx-sdma: add mcu_2_ecspi script
>   spi: imx: fix ERR009165
>   spi: imx: remove ERR009165 workaround on i.mx6ul
>   dt-bindings: spi: imx: add i.mx6ul to state errata fixed
>   dmaengine: imx-sdma: remove ERR009165 on i.mx6ul
>   dt-bindings: dma: imx-sdma: add i.mx6ul/6sx compatible name
>   dmaengine: imx-sdma: fix ecspi1 rx dma not work on i.mx8mm
>   ARM64: dts: freescale: imx8mm/8mq: update new compatible name for
>     ecspi and sdma
>   ARM: dts: imx6ul: add dma support on ecspi
>   ARM: dts: imx6sll: correct ecspi/sdma compatible
>   arm64: defconfig: Enable SDMA on i.mx8mq/8mm
> 
>  .../devicetree/bindings/dma/fsl-imx-sdma.txt       |  2 +
>  .../devicetree/bindings/spi/fsl-imx-cspi.txt       |  2 +
>  arch/arm/boot/dts/imx6q.dtsi                       |  2 +-
>  arch/arm/boot/dts/imx6qdl.dtsi                     |  8 +--
>  arch/arm/boot/dts/imx6sll.dtsi                     | 10 ++--
>  arch/arm/boot/dts/imx6ul.dtsi                      |  8 +++
>  arch/arm64/boot/dts/freescale/imx8mm.dtsi          | 14 ++---
>  arch/arm64/boot/dts/freescale/imx8mq.dtsi          |  6 +-
>  arch/arm64/configs/defconfig                       |  3 +
>  drivers/dma/imx-sdma.c                             | 67 ++++++++++++++++------
>  drivers/spi/spi-imx.c                              | 46 ++++++++++++---
>  include/linux/platform_data/dma-imx-sdma.h         |  1 +
>  12 files changed, 124 insertions(+), 45 deletions(-)
> 
> -- 
> 2.7.4
>