linux-kernel - Re: [PATCH net-next 0/3] make nla_nest_start() add NLA_F

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 26 Apr 2019 11:24:15 +0200
From:   Johannes Berg <johannes@...solutions.net>
To:     Michal Kubecek <mkubecek@...e.cz>,
        "David S. Miller" <davem@...emloft.net>
Cc:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        David Ahern <dsahern@...il.com>,
        Jiri Pirko <jiri@...lanox.com>,
        Pablo Neira Ayuso <pablo@...filter.org>,
        Jozsef Kadlecsik <kadlec@...ckhole.kfki.hu>,
        Florian Westphal <fw@...len.de>,
        "netfilter-devel@...r.kernel.org" <netfilter-devel@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next 0/3] make nla_nest_start() add NLA_F_NESTED flag

On Fri, 2019-04-26 at 09:13 +0000, Michal Kubecek wrote:

> Another observation was that even if NLA_F_NESTED flag was introduced in
> 2007, only few netlink based interfaces set it in kernel generated messages
> and even many recently added APIs omit it. That is unfortunate as without
> the flag, message parsers not familiar with attribute semantics cannot
> recognize nested attributes and do not see message structure; this affects
> e.g. wireshark dissector or mnl_nlmsg_fprintf() from libmnl.

Indeed.

I wonder if we should also (start) enforcing that the userspace sender
side sets this, if the policy is strict?

johannes