linux-kernel - Re: [EXT] Re: [PATCH v2 07/15] spi: imx: remove ERR009165 workaround on i.mx6ul

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 26 Apr 2019 09:32:29 +0000
From:   Robin Gong <yibin.gong@....com>
To:     "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "u.kleine-koenig@...gutronix.de" <u.kleine-koenig@...gutronix.de>,
        "festevam@...il.com" <festevam@...il.com>,
        "plyatov@...il.com" <plyatov@...il.com>,
        "broonie@...nel.org" <broonie@...nel.org>,
        "dan.j.williams@...el.com" <dan.j.williams@...el.com>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "catalin.marinas@....com" <catalin.marinas@....com>,
        "will.deacon@....com" <will.deacon@....com>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "l.stach@...gutronix.de" <l.stach@...gutronix.de>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>
CC:     "linux-spi@...r.kernel.org" <linux-spi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "dmaengine@...r.kernel.org" <dmaengine@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [EXT] Re: [PATCH v2 07/15] spi: imx: remove ERR009165 workaround
 on i.mx6ul

On 2019-04-26 at 11:09 +0200, Lucas Stach wrote:
> 
> >  static inline int is_imx53_ecspi(struct spi_imx_data *d)
> > @@ -585,9 +587,16 @@ static int mx51_ecspi_prepare_transfer(struct
> > spi_imx_data *spi_imx,
> >       ctrl |= mx51_ecspi_clkdiv(spi_imx, t->speed_hz, &clk);
> >       spi_imx->spi_bus_clk = clk;
> > 
> > -     /* ERR009165: work in XHC mode as PIO */
> > -     if (spi_imx->usedma)
> > -             ctrl &= ~MX51_ECSPI_CTRL_SMC;
> > +     /*
> > +      * ERR009165: work in XHC mode instead of SMC as PIO on the
> > chips
> > +      * before i.mx6ul.
> > +      */
> > +     if (spi_imx->usedma) {
> > +             if (spi_imx->devtype_data->devtype == IMX6UL_ECSPI)
> > 
> > =, otherwise the workaround might be applied to later generations
> > of
> the core if more are added later.
> 
> Regards,
> Lucas
Understood your point, but for now choose different compatible name
could apply this workaround or not. I prefer to leave it for next ecspi
IP upgrade if it really come in the future, otherwise that '>=' bring
a little bit confuse if there is no update for ecspi IP...