linux-kernel - Re: [PATCH] power: supply: bq27xxx_battery: Notify also about status changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJKOXPedb=TX=4ZDW4SARPBb5_K_zMFVBA3wJCYTieTuxk+9xg@mail.gmail.com>
Date:   Fri, 26 Apr 2019 11:57:56 +0200
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Pali Rohár <pali.rohar@...il.com>
Cc:     "Andrew F. Davis" <afd@...com>, Sebastian Reichel <sre@...nel.org>,
        linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] power: supply: bq27xxx_battery: Notify also about status changes

On Fri, 26 Apr 2019 at 11:32, Pali Rohár <pali.rohar@...il.com> wrote:
>
> On Friday 26 April 2019 11:26:48 Krzysztof Kozlowski wrote:
> > User-space might be interested in receiving uevents when the charging
> > starts/stops or if conditions of battery changes (e.g.
> > over-temperature).  Notify about changes in battery also when the flags
> > change, not only SoC.
>
> This looks like a good idea.
>
> > Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>
> > ---
> >  drivers/power/supply/bq27xxx_battery.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/power/supply/bq27xxx_battery.c b/drivers/power/supply/bq27xxx_battery.c
> > index 29b3a4056865..cb9306160c14 100644
> > --- a/drivers/power/supply/bq27xxx_battery.c
> > +++ b/drivers/power/supply/bq27xxx_battery.c
> > @@ -1612,7 +1612,8 @@ void bq27xxx_battery_update(struct bq27xxx_device_info *di)
> >                       di->charge_design_full = bq27xxx_battery_read_dcap(di);
> >       }
> >
> > -     if (di->cache.capacity != cache.capacity)
> > +     if ((di->cache.capacity != cache.capacity) || \
>                                                       ^^
>                                       You have there an extra backslash

Indeed, Thanks! Let me send v2.

Best regards,
Krzysztof