linux-kernel - Re: [PATCH 1/7] rtc: jz4740: set range

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+7wUsxD1ydvS3yA_ZTvTRXZcg8F4SFTwa2yArq7J00KxFZgiw@mail.gmail.com>
Date:   Fri, 26 Apr 2019 16:31:35 +0200
From:   Mathieu Malaterre <malat@...ian.org>
To:     Alexandre Belloni <alexandre.belloni@...tlin.com>
Cc:     linux-rtc@...r.kernel.org, Paul Cercueil <paul@...pouillou.net>,
        linux-arm-kernel@...ts.infradead.org,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/7] rtc: jz4740: set range

On Thu, Apr 18, 2019 at 12:01 PM Alexandre Belloni
<alexandre.belloni@...tlin.com> wrote:
>
> RTC_SEC is a 32-bit seconds counter.

For the entire series:

Tested-by: Mathieu Malaterre <malat@...ian.org>

Arch is MIPS Creator CI20

>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@...tlin.com>
> ---
>  drivers/rtc/rtc-jz4740.c | 12 ++++++++++--
>  1 file changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/rtc/rtc-jz4740.c b/drivers/rtc/rtc-jz4740.c
> index d0a891777f44..079469627bd7 100644
> --- a/drivers/rtc/rtc-jz4740.c
> +++ b/drivers/rtc/rtc-jz4740.c
> @@ -348,10 +348,18 @@ static int jz4740_rtc_probe(struct platform_device *pdev)
>
>         device_init_wakeup(&pdev->dev, 1);
>
> -       rtc->rtc = devm_rtc_device_register(&pdev->dev, pdev->name,
> -                                       &jz4740_rtc_ops, THIS_MODULE);
> +       rtc->rtc = devm_rtc_allocate_device(&pdev->dev);
>         if (IS_ERR(rtc->rtc)) {
>                 ret = PTR_ERR(rtc->rtc);
> +               dev_err(&pdev->dev, "Failed to allocate rtc device: %d\n", ret);
> +               return ret;
> +       }
> +
> +       rtc->rtc->ops = &jz4740_rtc_ops;
> +       rtc->rtc->range_max = U32_MAX;
> +
> +       ret = rtc_register_device(rtc->rtc);
> +       if (ret) {
>                 dev_err(&pdev->dev, "Failed to register rtc device: %d\n", ret);
>                 return ret;
>         }
> --
> 2.20.1
>