linux-kernel - Re: [PATCH 2/3] power: supply: Add driver for Microchip UCS1002

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1556289824.2584.36.camel@pengutronix.de>
Date:   Fri, 26 Apr 2019 16:43:44 +0200
From:   Lucas Stach <l.stach@...gutronix.de>
To:     Andrey Smirnov <andrew.smirnov@...il.com>, linux-pm@...r.kernel.org
Cc:     Chris Health <cphealy@...il.com>,
        Fabio Estevam <fabio.estevam@....com>,
        Guenter Roeck <linux@...ck-us.net>,
        Sebastian Reichel <sre@...nel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] power: supply: Add driver for Microchip UCS1002

Hi Andrey,

Am Mittwoch, den 17.04.2019, 01:44 -0700 schrieb Andrey Smirnov:
> Add driver for Microchip UCS1002 Programmable USB Port Power
> Controller with Charger Emulation. The driver exposed a power supply
> device to control/monitor various parameter of the device as well as a
> regulator to allow controlling VBUS line.
> 
> > Signed-off-by: Andrey Smirnov <andrew.smirnov@...il.com>
> > Cc: Chris Health <cphealy@...il.com>
> > Cc: Lucas Stach <l.stach@...gutronix.de>
> > Cc: Fabio Estevam <fabio.estevam@....com>
> > Cc: Guenter Roeck <linux@...ck-us.net>
> > Cc: Sebastian Reichel <sre@...nel.org>
> Cc: linux-kernel@...r.kernel.org
> Cc: linux-pm@...r.kernel.org
> ---
[...]
> +	if (irq_a_det > 0) {
> > +		ret = devm_request_threaded_irq(dev, irq_a_det, NULL,
> > +						ucs1002_charger_irq,
> > +						IRQF_TRIGGER_FALLING |
> > +						IRQF_TRIGGER_RISING |
> > +						IRQF_ONESHOT,
> > +						"ucs1002-a_det", info);
> > +		if (ret) {
> > +			dev_err(dev, "failed to request A_DET threaded irq\n");
> > +			return ret;
> > +		}
> > +	}
> +
> > +	if (irq_alert > 0) {
> > +		ret = devm_request_threaded_irq(dev, irq_alert, NULL,
> > +						ucs1002_alert_irq,
> > +						IRQF_TRIGGER_FALLING |
> > +						IRQF_TRIGGER_RISING |
> > +						IRQF_ONESHOT,
> > +						"ucs1002-alert", info);
> > +		if (ret) {
> > +			dev_err(dev, "failed to request ALERT threaded irq\n");
> > +			return ret;
> > +		}
> > +	}

Any reason to explicitly set the IRQ trigger type here? Normally I
would expect this to be set via the DT interrupt specifier.

Regards,
Lucas