linux-kernel - Re: [PATCH] mfd: intel_quark_i2c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 26 Apr 2019 17:44:54 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Jan Kiszka <jan.kiszka@...mens.com>
Cc:     Lee Jones <lee.jones@...aro.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        Su Bao Cheng <baocheng.su@...mens.com>
Subject: Re: [PATCH] mfd: intel_quark_i2c_gpio: Adjust IOT2000 matching

On Thu, Apr 18, 2019 at 12:15 PM Jan Kiszka <jan.kiszka@...mens.com> wrote:
>
> From: Su Bao Cheng <baocheng.su@...mens.com>
>
> Since there are more IOT2040 variants with identical hardware but
> different asset tags, the asset tag matching should be adjusted to
> support them.
>
> For the board name "SIMATIC IOT2000", currently there are 2 types of
> hardware, IOT2020 and IOT2040. Both are identical regarding the
> intel_quark_i2c_gpio. In the future there will be no other devices with
> the "SIMATIC IOT2000" DMI board name but different hardware. So remove
> the asset tag matching from this driver.
>

Acked-by: Andy Shevchenko <andy.shevchenko@...il.com>

> Signed-off-by: Su Bao Cheng <baocheng.su@...mens.com>
> Reviewed-by: Jan Kiszka <jan.kiszka@...mens.com>
> ---
>  drivers/mfd/intel_quark_i2c_gpio.c | 10 ----------
>  1 file changed, 10 deletions(-)
>
> diff --git a/drivers/mfd/intel_quark_i2c_gpio.c b/drivers/mfd/intel_quark_i2c_gpio.c
> index 5bddb84cfc1f..11adbf77960d 100644
> --- a/drivers/mfd/intel_quark_i2c_gpio.c
> +++ b/drivers/mfd/intel_quark_i2c_gpio.c
> @@ -74,16 +74,6 @@ static const struct dmi_system_id dmi_platform_info[] = {
>         {
>                 .matches = {
>                         DMI_EXACT_MATCH(DMI_BOARD_NAME, "SIMATIC IOT2000"),
> -                       DMI_EXACT_MATCH(DMI_BOARD_ASSET_TAG,
> -                                       "6ES7647-0AA00-0YA2"),
> -               },
> -               .driver_data = (void *)400000,
> -       },
> -       {
> -               .matches = {
> -                       DMI_EXACT_MATCH(DMI_BOARD_NAME, "SIMATIC IOT2000"),
> -                       DMI_EXACT_MATCH(DMI_BOARD_ASSET_TAG,
> -                                       "6ES7647-0AA00-1YA2"),
>                 },
>                 .driver_data = (void *)400000,
>         },
> --
> 2.16.4



-- 
With Best Regards,
Andy Shevchenko