linux-kernel - Re: [RFC PATCH v5 4/4] x86/acrn: Add hypercall for ACRN guest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <473d145c-4bfd-4ec8-34c3-8a26a78fe40d@intel.com>
Date:   Fri, 26 Apr 2019 11:18:48 +0800
From:   "Zhao, Yakui" <yakui.zhao@...el.com>
To:     Borislav Petkov <bp@...en8.de>
Cc:     Ingo Molnar <mingo@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "x86@...nel.org" <x86@...nel.org>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "Chen, Jason CJ" <jason.cj.chen@...el.com>
Subject: Re: [RFC PATCH v5 4/4] x86/acrn: Add hypercall for ACRN guest



On 2019年04月25日 19:00, Borislav Petkov wrote:
> On Thu, Apr 25, 2019 at 06:16:02PM +0800, Zhao, Yakui wrote:
>> The parameter register for the VMCALL is predefined in ACRN hypervisor. Now
>> the R8 is used to pass the hcall_id.
>> It seems that there is no special constraint for R8~R15.
>> So the explicit register variable is used so that the R8 can be passed.
> 
> If you're going to use the constraint "D" for param1, you can just as
> well do
> 
> 	"=a" (result)
> 
> everywhere since you have the letter constraint for %rax instead of
> declaring it with "register".
> 
> Also, you can completely get rid of those "register" declarations
> and let gcc have all the freedom to pass in hcall_id and the other
> parameters:
Thanks Borislav for providing the code.

It seems that it is seldom used in kernel although the explicit register 
variable is supported by GCC and makes the code look simpler. And it 
seems that the explicit register variable is not suppoorted by CLAG.


So the explicit register variable will be removed. I will follow the asm 
code from Borislav. Of course one minor change is that the "movq" is 
used instead of "mov".

Is this ok?

Thanks

> 
> 	unsigned long result;
> 
>          asm volatile("mov %[hcall_id], %%r8\n\t"
>                       "vmcall\n\t"
>                       : "=a" (result)
>                       : [hcall_id] "g" (hcall_id)
>                       : "r8");
> 
>          return result;
> 
> and %r8 will be in the clobber list so gcc will reload it if needed.
> 
> gcc turns it into
> 
> 0000000000001040 <main>:
>      1040:       4c 8b 05 e1 2f 00 00    mov    0x2fe1(%rip),%r8        # 4028 <hcall_id>
>      1047:       0f 01 c1                vmcall
>      104a:       c3                      retq
>      104b:       0f 1f 44 00 00          nopl   0x0(%rax,%rax,1)
> 
> here.
>