linux-kernel - Re: [PATCH net-next] cxgb4/cxgb4vf_main: Mark expected switch fall-through

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 26 Apr 2019 11:29:39 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     gustavo@...eddedor.com
Cc:     leedom@...lsio.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, keescook@...omium.org
Subject: Re: [PATCH net-next] cxgb4/cxgb4vf_main: Mark expected switch
 fall-through

From: "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Date: Wed, 24 Apr 2019 11:27:42 -0500

> In preparation to enabling -Wimplicit-fallthrough, mark switch
> cases where we are expecting to fall through.
> 
> This patch fixes the following warning:
> 
> drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c: In function ‘fwevtq_handler’:
> drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c:520:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
>    cpl = (void *)p;
>    ~~~~^~~~~~~~~~~
> drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c:524:2: note: here
>   case CPL_SGE_EGR_UPDATE: {
>   ^~~~
> 
> Warning level 3 was used: -Wimplicit-fallthrough=3
> 
> Notice that, in this particular case, the code comment is modified
> in accordance with what GCC is expecting to find.
> 
> This patch is part of the ongoing efforts to enable
> -Wimplicit-fallthrough.
> 
> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>

Applied.