linux-kernel - Re: [PATCH v2 2/2] staging: rtl8192u: ieee80211: Fix spelling mistake

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 26 Apr 2019 10:31:27 -0500
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     Vatsala Narang <vatsalanarang@...il.com>,
        gregkh@...uxfoundation.org
Cc:     devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
        Julia.Lawall@...6.fr
Subject: Re: [PATCH v2 2/2] staging: rtl8192u: ieee80211: Fix spelling mistake

Hi Vatsala,

On 4/26/19 3:43 AM, Vatsala Narang wrote:
> Replace explicitely with explicitly to get rid of checkpatch warning.
> 
> Signed-off-by: Vatsala Narang <vatsalanarang@...il.com>
> ---
> Changes in v2:
> -added this patch to patchset to fix spelling mistake.
> 

When you create a series, it is a good thing to include a cover letter,
in particular in cases like this, in which there is no v1 of this
patch.  Notice that you have just created a v2 of a previously
non-existent series. This can create confusion for maintainers
were you addressing a more complex task.

I might be a bit picky here, but be sure that any extra time you
invest in the first stages as a kernel contributor will pay off
in the future. :)

Anyway, here is my

Acked-by: Gustavo A. R. Silva <gustavo@...eddedor.com>

for both patches.

Thanks and keep contributing.
--
Gustavo

>  drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c
> index 2044ae27b973..9631331b79d5 100644
> --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c
> +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c
> @@ -396,7 +396,8 @@ int ieee80211_wx_set_encode(struct ieee80211_device *ieee,
>  				       (*crypt)->priv);
>  		sec.flags |= BIT(key);
>  		/* This ensures a key will be activated if no key is
> -		 * explicitely set */
> +		 * explicitly set
> +		 */
>  		if (key == sec.active_key)
>  			sec.flags |= SEC_ACTIVE_KEY;
>  		ieee->tx_keyidx = key;
>