linux-kernel - Re: [PATCH 2/3] power: supply: Add driver for Microchip UCS1002

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 26 Apr 2019 10:04:37 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Enric Balletbo Serra <eballetbo@...il.com>
Cc:     Andrey Smirnov <andrew.smirnov@...il.com>,
        Linux PM list <linux-pm@...r.kernel.org>,
        Chris Health <cphealy@...il.com>,
        Lucas Stach <l.stach@...gutronix.de>,
        Fabio Estevam <fabio.estevam@....com>,
        Sebastian Reichel <sre@...nel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/3] power: supply: Add driver for Microchip UCS1002

On Fri, Apr 26, 2019 at 06:51:51PM +0200, Enric Balletbo Serra wrote:
> Hi Andrey,
> 
> Many thanks to push this upstream. Actually this the fifth version [1]
> of this patchset. I think that is interesting for the maintainers
> maintain the history and the changelog.
> 
> [1] https://lkml.org/lkml/2016/3/14/233
> 
> Missatge de Andrey Smirnov <andrew.smirnov@...il.com> del dia dc., 17
> d’abr. 2019 a les 10:46:
> >
> > Add driver for Microchip UCS1002 Programmable USB Port Power
> > Controller with Charger Emulation. The driver exposed a power supply
> > device to control/monitor various parameter of the device as well as a
> > regulator to allow controlling VBUS line.
> >
> > Signed-off-by: Andrey Smirnov <andrew.smirnov@...il.com>
> > Cc: Chris Health <cphealy@...il.com>
> > Cc: Lucas Stach <l.stach@...gutronix.de>
> > Cc: Fabio Estevam <fabio.estevam@....com>
> > Cc: Guenter Roeck <linux@...ck-us.net>
> > Cc: Sebastian Reichel <sre@...nel.org>
> > Cc: linux-kernel@...r.kernel.org
> > Cc: linux-pm@...r.kernel.org
> > ---

...

> > +       static const int bit_weights_uAh[BITS_PER_TYPE(u32)] = {
> > +               0, 0, 0, 0, 0, 0, 3, 5,
> > +
> 
> nit: I personally don't like these empty lines here.
> 
I stumbled over those as well, but then I realized that they
split up the 32 bit into bytes, so it does make some sense. 

Guenter