linux-kernel - Re: [PATCH v2] iio: dac: ad5758: declare missing of table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190427135906.455c468b@archlinux>
Date:   Sat, 27 Apr 2019 13:59:06 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Daniel Gomez <dagmcr@...il.com>
Cc:     Stefan Popa <stefan.popa@...log.com>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Michael Hennerich <Michael.Hennerich@...log.com>,
        Hartmut Knaack <knaack.h@....de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        linux-iio@...r.kernel.org (open list:ANALOG DEVICES INC AD5758 DRIVER),
        linux-kernel@...r.kernel.org (open list), javier@...hile0.org
Subject: Re: [PATCH v2] iio: dac: ad5758: declare missing of table

On Tue, 23 Apr 2019 23:41:58 +0200
Daniel Gomez <dagmcr@...il.com> wrote:

> Add missing <of_device_id> table for SPI driver relying on SPI
> device match since compatible is in a DT binding or in a DTS.
> 
> Before this patch:
> modinfo drivers/iio/dac/ad5758.ko | grep alias
> alias:          spi:ad5758
> 
> After this patch:
> modinfo drivers/iio/dac/ad5758.ko | grep alias
> alias:          spi:ad5758
> alias:          of:N*T*Cadi,ad5758C*
> alias:          of:N*T*Cadi,ad5758
> 
> Reported-by: Javier Martinez Canillas <javier@...hile0.org>
> Signed-off-by: Daniel Gomez <dagmcr@...il.com>
Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to play with it.

Thanks,

Jonathan

> ---
>  drivers/iio/dac/ad5758.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/drivers/iio/dac/ad5758.c b/drivers/iio/dac/ad5758.c
> index 2bdf1b0..e8eaa48 100644
> --- a/drivers/iio/dac/ad5758.c
> +++ b/drivers/iio/dac/ad5758.c
> @@ -11,6 +11,8 @@
>  #include <linux/kernel.h>
>  #include <linux/module.h>
>  #include <linux/property.h>
> +#include <linux/of.h>
> +#include <linux/of_device.h>
>  #include <linux/spi/spi.h>
>  #include <linux/gpio/consumer.h>
>  
> @@ -904,9 +906,16 @@ static const struct spi_device_id ad5758_id[] = {
>  };
>  MODULE_DEVICE_TABLE(spi, ad5758_id);
>  
> +static const struct of_device_id ad5758_of_match[] = {
> +        { .compatible = "adi,ad5758" },
> +        { },
> +};
> +MODULE_DEVICE_TABLE(of, ad5758_of_match);
> +
>  static struct spi_driver ad5758_driver = {
>  	.driver = {
>  		.name = KBUILD_MODNAME,
> +		.of_match_table = ad5758_of_match,
>  	},
>  	.probe = ad5758_probe,
>  	.id_table = ad5758_id,