linux-kernel - Re: [PATCH -next] iio: dac: ad5758: remove set but not used variable 'dc_dc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190427141642.673f33f3@archlinux>
Date:   Sat, 27 Apr 2019 14:16:42 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Yue Haibing <yuehaibing@...wei.com>
Cc:     <stefan.popa@...log.com>, <lars@...afoo.de>,
        <Michael.Hennerich@...log.com>, <knaack.h@....de>,
        <pmeerw@...erw.net>, <linux-kernel@...r.kernel.org>,
        <linux-iio@...r.kernel.org>
Subject: Re: [PATCH -next] iio: dac: ad5758: remove set but not used
 variable 'dc_dc_mode'

On Sat, 27 Apr 2019 00:40:06 +0800
Yue Haibing <yuehaibing@...wei.com> wrote:

> From: YueHaibing <yuehaibing@...wei.com>
> 
> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> drivers/iio/dac/ad5758.c: In function ad5758_write_powerdown:
> drivers/iio/dac/ad5758.c:585:15: warning: variable dc_dc_mode set but not used [-Wunused-but-set-variable]
> 
> It is not used any more since
> commit edde945257e2 ("iio: dac: ad5758: Modifications for new revision")
> 
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to play with it.

Thanks,

Jonathan

> ---
>  drivers/iio/dac/ad5758.c | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/iio/dac/ad5758.c b/drivers/iio/dac/ad5758.c
> index a513c70..570f69e 100644
> --- a/drivers/iio/dac/ad5758.c
> +++ b/drivers/iio/dac/ad5758.c
> @@ -582,7 +582,7 @@ static ssize_t ad5758_write_powerdown(struct iio_dev *indio_dev,
>  {
>  	struct ad5758_state *st = iio_priv(indio_dev);
>  	bool pwr_down;
> -	unsigned int dc_dc_mode, dac_config_mode, val;
> +	unsigned int dac_config_mode, val;
>  	unsigned long int dac_config_msk;
>  	int ret;
>  
> @@ -591,13 +591,10 @@ static ssize_t ad5758_write_powerdown(struct iio_dev *indio_dev,
>  		return ret;
>  
>  	mutex_lock(&st->lock);
> -	if (pwr_down) {
> -		dc_dc_mode = AD5758_DCDC_MODE_POWER_OFF;
> +	if (pwr_down)
>  		val = 0;
> -	} else {
> -		dc_dc_mode = st->dc_dc_mode;
> +	else
>  		val = 1;
> -	}
>  
>  	dac_config_mode = AD5758_DAC_CONFIG_OUT_EN_MODE(val) |
>  			  AD5758_DAC_CONFIG_INT_EN_MODE(val);