linux-kernel - Re: [PATCH -next] counter: 104-quad-8: Make quad8

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190427002720.GA26000@icarus>
Date:   Sat, 27 Apr 2019 09:27:20 +0900
From:   William Breathitt Gray <vilhelm.gray@...il.com>
To:     Yue Haibing <yuehaibing@...wei.com>
Cc:     gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
        linux-iio@...r.kernel.org
Subject: Re: [PATCH -next] counter: 104-quad-8: Make quad8_ops static

On Sat, Apr 27, 2019 at 12:48:16AM +0800, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@...wei.com>
> 
> Fix sparse warning:
> 
> drivers/counter/104-quad-8.c:836:26: warning:
>  symbol 'quad8_ops' was not declared. Should it be static?
> 
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>  drivers/counter/104-quad-8.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/counter/104-quad-8.c b/drivers/counter/104-quad-8.c
> index 4fa2931..00b113f 100644
> --- a/drivers/counter/104-quad-8.c
> +++ b/drivers/counter/104-quad-8.c
> @@ -833,7 +833,7 @@ static int quad8_action_get(struct counter_device *counter,
>  	return 0;
>  }
>  
> -const struct counter_ops quad8_ops = {
> +static const struct counter_ops quad8_ops = {
>  	.signal_read = quad8_signal_read,
>  	.count_read = quad8_count_read,
>  	.count_write = quad8_count_write,
> -- 
> 2.7.4

Yes, thank you, this should be static.

Acked-by: William Breathitt Gray <vilhelm.gray@...il.com>