lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sat, 27 Apr 2019 16:13:09 +0100
From:   Ben Hutchings <>
CC:, Denis Kirjanov <>,
        "Waiman Long" <>,
        "Linus Torvalds" <>,
        "Dave Chinner" <>
Subject: [PATCH 3.16 079/202] fs/dcache: Fix incorrect nr_dentry_unused
 accounting in shrink_dcache_sb()

3.16.66-rc1 review patch.  If anyone has any objections, please let me know.


From: Waiman Long <>

commit 1dbd449c9943e3145148cc893c2461b72ba6fef0 upstream.

The nr_dentry_unused per-cpu counter tracks dentries in both the LRU
lists and the shrink lists where the DCACHE_LRU_LIST bit is set.

The shrink_dcache_sb() function moves dentries from the LRU list to a
shrink list and subtracts the dentry count from nr_dentry_unused.  This
is incorrect as the nr_dentry_unused count will also be decremented in
shrink_dentry_list() via d_shrink_del().

To fix this double decrement, the decrement in the shrink_dcache_sb()
function is taken out.

Fixes: 4e717f5c1083 ("list_lru: remove special case function list_lru_dispose_all."
Signed-off-by: Waiman Long <>
Reviewed-by: Dave Chinner <>
Signed-off-by: Linus Torvalds <>
Signed-off-by: Ben Hutchings <>
 fs/dcache.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

--- a/fs/dcache.c
+++ b/fs/dcache.c
@@ -1063,15 +1063,11 @@ static enum lru_status dentry_lru_isolat
 void shrink_dcache_sb(struct super_block *sb)
-	long freed;
 	do {
-		freed = list_lru_walk(&sb->s_dentry_lru,
+		list_lru_walk(&sb->s_dentry_lru,
 			dentry_lru_isolate_shrink, &dispose, 1024);
-		this_cpu_sub(nr_dentry_unused, freed);
 	} while (list_lru_count(&sb->s_dentry_lru) > 0);

Powered by blists - more mailing lists