linux-kernel - [PATCH 3.16 027/202] ARM: dts: kirkwood: Fix polarity of GPIO fan lines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 27 Apr 2019 16:13:09 +0100
From:   Ben Hutchings <ben@...adent.org.uk>
To:     linux-kernel@...r.kernel.org, stable@...r.kernel.org
CC:     akpm@...ux-foundation.org, Denis Kirjanov <kda@...ux-powerpc.org>,
        "Sebastian Hesselbarth" <sebastian.hesselbarth@...il.com>,
        "Julien D'Ascenzio" <jdascenzio@...teo.net>,
        "Andrew Lunn" <andrew@...n.ch>,
        "Guenter Roeck" <linux@...ck-us.net>,
        "Linus Walleij" <linus.walleij@...aro.org>,
        "Jamie Lentin" <jm@...tin.co.uk>,
        "Gregory Clement" <gregory.clement@...tlin.com>,
        "Jason Cooper" <jason@...edaemon.net>
Subject: [PATCH 3.16 027/202] ARM: dts: kirkwood: Fix polarity of GPIO fan
 lines

3.16.66-rc1 review patch.  If anyone has any objections, please let me know.

------------------

From: Linus Walleij <linus.walleij@...aro.org>

commit b5f034845e70916fd33e172fad5ad530a29c10ab upstream.

These two lines are active high, not active low. The bug was
found when we changed the kernel to respect the polarity defined
in the device tree.

Fixes: 1b90e06b1429 ("ARM: kirkwood: Use devicetree to define DNS-32[05] fan")
Cc: Jamie Lentin <jm@...tin.co.uk>
Cc: Guenter Roeck <linux@...ck-us.net>
Cc: Jason Cooper <jason@...edaemon.net>
Cc: Andrew Lunn <andrew@...n.ch>
Cc: Gregory Clement <gregory.clement@...tlin.com>
Cc: Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>
Cc: Julien D'Ascenzio <jdascenzio@...teo.net>
Reviewed-by: Andrew Lunn <andrew@...n.ch>
Tested-by: Jamie Lentin <jm@...tin.co.uk>
Reported-by: Julien D'Ascenzio <jdascenzio@...teo.net>
Tested-by: Julien D'Ascenzio <jdascenzio@...teo.net>
Signed-off-by: Linus Walleij <linus.walleij@...aro.org>
Signed-off-by: Gregory CLEMENT <gregory.clement@...tlin.com>
Signed-off-by: Ben Hutchings <ben@...adent.org.uk>
---
 arch/arm/boot/dts/kirkwood-dnskw.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- a/arch/arm/boot/dts/kirkwood-dnskw.dtsi
+++ b/arch/arm/boot/dts/kirkwood-dnskw.dtsi
@@ -35,8 +35,8 @@
 		compatible = "gpio-fan";
 		pinctrl-0 = <&pmx_fan_high_speed &pmx_fan_low_speed>;
 		pinctrl-names = "default";
-		gpios = <&gpio1 14 GPIO_ACTIVE_LOW
-			 &gpio1 13 GPIO_ACTIVE_LOW>;
+		gpios = <&gpio1 14 GPIO_ACTIVE_HIGH
+			 &gpio1 13 GPIO_ACTIVE_HIGH>;
 		gpio-fan,speed-map = <0    0
 				      3000 1
 				      6000 2>;