linux-kernel - Re: [PATCH] irqchip/imx-irqsteer: use devm_platform_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <86sgu2a2yl.wl-marc.zyngier@arm.com>
Date:   Sun, 28 Apr 2019 10:33:54 +0100
From:   Marc Zyngier <marc.zyngier@....com>
To:     Anson Huang <anson.huang@....com>
Cc:     Mukesh Ojha <mojha@...eaurora.org>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "jason@...edaemon.net" <jason@...edaemon.net>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "festevam@...il.com" <festevam@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        dl-linux-imx <linux-imx@....com>
Subject: Re: [PATCH] irqchip/imx-irqsteer: use devm_platform_ioremap_resource() to simplify code

On Sun, 28 Apr 2019 07:28:20 +0100,
Anson Huang <anson.huang@....com> wrote:
> 
> Ping...

I'm still building the 5.2 branch, no need to panic just yet.

Thanks,

	M.

> 
> > -----Original Message-----
> > From: Mukesh Ojha [mailto:mojha@...eaurora.org]
> > Sent: Monday, April 1, 2019 3:47 PM
> > To: Anson Huang <anson.huang@....com>; tglx@...utronix.de;
> > jason@...edaemon.net; marc.zyngier@....com; shawnguo@...nel.org;
> > s.hauer@...gutronix.de; kernel@...gutronix.de; festevam@...il.com;
> > linux-kernel@...r.kernel.org; linux-arm-kernel@...ts.infradead.org
> > Cc: dl-linux-imx <linux-imx@....com>
> > Subject: Re: [PATCH] irqchip/imx-irqsteer: use
> > devm_platform_ioremap_resource() to simplify code
> > 
> > 
> > On 4/1/2019 11:51 AM, Anson Huang wrote:
> > > Use the new helper devm_platform_ioremap_resource() which wraps the
> > > platform_get_resource() and devm_ioremap_resource() together, to
> > > simplify the code.
> > >
> > > Signed-off-by: Anson Huang <Anson.Huang@....com>
> > Reviewed-by: Mukesh Ojha <mojha@...eaurora.org>
> > 
> > Cheers,
> > -Mukesh
> > > ---
> > >   drivers/irqchip/irq-imx-irqsteer.c | 4 +---
> > >   1 file changed, 1 insertion(+), 3 deletions(-)
> > >
> > > diff --git a/drivers/irqchip/irq-imx-irqsteer.c
> > > b/drivers/irqchip/irq-imx-irqsteer.c
> > > index 88df3d00..290531e 100644
> > > --- a/drivers/irqchip/irq-imx-irqsteer.c
> > > +++ b/drivers/irqchip/irq-imx-irqsteer.c
> > > @@ -144,7 +144,6 @@ static int imx_irqsteer_probe(struct
> > platform_device *pdev)
> > >   {
> > >   	struct device_node *np = pdev->dev.of_node;
> > >   	struct irqsteer_data *data;
> > > -	struct resource *res;
> > >   	u32 irqs_num;
> > >   	int i, ret;
> > >
> > > @@ -152,8 +151,7 @@ static int imx_irqsteer_probe(struct
> > platform_device *pdev)
> > >   	if (!data)
> > >   		return -ENOMEM;
> > >
> > > -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > > -	data->regs = devm_ioremap_resource(&pdev->dev, res);
> > > +	data->regs = devm_platform_ioremap_resource(pdev, 0);
> > >   	if (IS_ERR(data->regs)) {
> > >   		dev_err(&pdev->dev, "failed to initialize reg\n");
> > >   		return PTR_ERR(data->regs);

-- 
Jazz is not dead, it just smell funny.