lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 28 Apr 2019 18:21:03 +0300 From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com> To: "Enrico Weigelt, metux IT consult" <info@...ux.net> Cc: linux-kernel@...r.kernel.org, gregkh@...uxfoundation.org, andrew@...id.au, macro@...ux-mips.org, vz@...ia.com, slemieux.tyco@...il.com, khilman@...libre.com, liviu.dudau@....com, sudeep.holla@....com, lorenzo.pieralisi@....com, davem@...emloft.net, jacmet@...site.dk, linux@...sktech.co.nz, matthias.bgg@...il.com, linux-mips@...r.kernel.org, linux-serial@...r.kernel.org, linux-ia64@...r.kernel.org, linux-amlogic@...ts.infradead.org, linuxppc-dev@...ts.ozlabs.org, sparclinux@...r.kernel.org Subject: Re: [PATCH 37/41] drivers: tty: serial: 8250: simplify io resource size computation On Sat, Apr 27, 2019 at 02:52:18PM +0200, Enrico Weigelt, metux IT consult wrote: > Simpily io resource size computation by setting mapsize field. > > Some of the special cases handled by serial8250_port_size() can be > simplified by putting this data to corresponding platform data > or probe function. > --- a/drivers/tty/serial/8250/8250.h > +++ b/drivers/tty/serial/8250/8250.h > @@ -105,6 +105,7 @@ struct serial8250_config { > > #define SERIAL8250_PORT(_base, _irq) SERIAL8250_PORT_FLAGS(_base, _irq, 0) > > +#define SERIAL_RT2880_IOSIZE 0x100 And why this is in the header file and not in corresponding C one? > diff --git a/drivers/tty/serial/8250/8250_port.c b/drivers/tty/serial/8250/8250_port.c > index d09af4c..51d6076 100644 > --- a/drivers/tty/serial/8250/8250_port.c > +++ b/drivers/tty/serial/8250/8250_port.c > @@ -2833,11 +2833,7 @@ unsigned int serial8250_port_size(struct uart_8250_port *pt) > { > if (pt->port.mapsize) > return pt->port.mapsize; > - if (pt->port.iotype == UPIO_AU) { > - if (pt->port.type == PORT_RT2880) > - return 0x100; > - return 0x1000; > - } > + > if (is_omap1_8250(pt)) > return 0x16 << pt->port.regshift; This is good. We definitely need to get rid of custom stuff in generic 8250_port, etc. -- With Best Regards, Andy Shevchenko
Powered by blists - more mailing lists